Page MenuHomeFreeBSD
Differential D42665

net/ts-warp: Add new port
ClosedPublic
Actions

Authored by otis on Nov 17 2023, 10:31 PM.
Tags
None
Referenced Files
F126511793: D42665.id130297.diff
Wed, Aug 20, 10:03 AM
Unknown Object (File)
Tue, Aug 19, 12:26 AM
Unknown Object (File)
Sun, Aug 17, 2:56 AM
Unknown Object (File)
Tue, Aug 12, 9:05 AM
Unknown Object (File)
Mon, Aug 4, 6:44 AM
Unknown Object (File)
Mon, Aug 4, 1:15 AM
Unknown Object (File)
Sat, Aug 2, 7:38 PM
Unknown Object (File)
Fri, Jul 25, 8:42 AM
View All Files
Subscribers
diizzy

Details

Reviewers
None
Commits
R11:ab04066dd703: net/ts-warp: Add new port
Summary

Add net/ts-warp port, Transparent proxy server and traffic wrapper.
WWW: https://github.com/mezantrop/ts-warp

Committing slightly modified version (reworked Makefile a bit,
corrected pkg-plist and rc.d script).

Also connect to the category's Makefile.

PR: 269460

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 54509
Build 51398: arc lint + arc unit

Event Timeline

otis requested review of this revision.Nov 17 2023, 10:31 PM
otis created this revision.
Harbormaster completed remote builds in B54503: Diff 130284.Nov 17 2023, 10:31 PM
otis updated this revision to Diff 130297.Nov 18 2023, 9:50 AM

Catch missed variable rename in rc.d script.

Harbormaster completed remote builds in B54509: Diff 130297.Nov 18 2023, 9:50 AM
otis updated this revision to Diff 130298.Nov 18 2023, 9:51 AM

Rebase

Harbormaster completed remote builds in B54510: Diff 130298.Nov 18 2023, 9:51 AM
diizzy added a subscriber: diizzy.Nov 18 2023, 2:59 PM
diizzy added inline comments.
net/ts-warp/Makefile
2 ↗(On Diff #130298)

I think a better fit since upstream appears to be active and tag release is to follow
"Example 18. Using USE_GITHUB to Access a Commit Between Two Versions" in Porters Handbook
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

12 ↗(On Diff #130298)

This is incorrect
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

20 ↗(On Diff #130298)

This should be fixed in Makefile and upstream

22 ↗(On Diff #130298)

While there are different opinions about this we usually only have manpanges as an option when there are dependencies

26 ↗(On Diff #130298)

Not needed

net/ts-warp/pkg-plist
5 ↗(On Diff #130298)

This should be handled in the rc.d script

otis updated this revision to Diff 130303.Nov 18 2023, 8:45 PM

Address comments.

Harbormaster completed remote builds in B54513: Diff 130303.Nov 18 2023, 8:45 PM
otis updated this revision to Diff 130304.Nov 18 2023, 8:47 PM
otis marked an inline comment as done.

Catch missed nit.

Harbormaster completed remote builds in B54514: Diff 130304.Nov 18 2023, 8:47 PM
otis marked 5 inline comments as done.Nov 18 2023, 8:48 PM
diizzy added a comment.Nov 18 2023, 9:42 PM

Thanks for fixing it up!

net/ts-warp/Makefile
15 ↗(On Diff #130304)

Can be dropped

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2023, 2:23 PM
Closed by commit R11:ab04066dd703: net/ts-warp: Add new port (authored by otis). · Explain Why
This revision was automatically updated to reflect the committed changes.
otis added a commit: R11:ab04066dd703: net/ts-warp: Add new port.

Revision Contents
Changeset List

PathSize
net/
ts-warp/
files/
3 lines

Diff 130297

View Options

net/ts-warp/files/tswarp.in

Loading...