Page MenuHomeFreeBSD

audio/spotify-player: Update to v0.15.2
ClosedPublic

Authored by jfree on Nov 16 2023, 8:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 10 2024, 10:41 AM
Unknown Object (File)
Apr 6 2024, 7:47 AM
Unknown Object (File)
Mar 31 2024, 5:52 AM
Unknown Object (File)
Feb 3 2024, 3:42 AM
Unknown Object (File)
Jan 18 2024, 2:44 PM
Unknown Object (File)
Jan 7 2024, 6:54 PM
Unknown Object (File)
Dec 24 2023, 9:28 PM
Unknown Object (File)
Dec 21 2023, 8:31 AM
Subscribers
None

Details

Reviewers
jrm
markj
Summary

We now build with Smithay client-toolkit v0.16.1, so patch-sctk should not be needed.

Changelog: https://github.com/aome510/spotify-player/releases

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jfree requested review of this revision.Nov 16 2023, 8:17 PM
jfree created this revision.
This revision is now accepted and ready to land.Nov 16 2023, 8:50 PM

Good to see this made it into the tree. The Committer's Guide describes helpful metadata, such as Approved by: and Differential Revision: to include in your commit logs. See https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer. Differential Revision: is helpful to refer a commit to review, and it also automatically closes the review after the commit. There is a commit log template you can install. See https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-getting-started.

In D42640#973086, @jrm wrote:

Good to see this made it into the tree. The Committer's Guide describes helpful metadata, such as Approved by: and Differential Revision: to include in your commit logs. See https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer. Differential Revision: is helpful to refer a commit to review, and it also automatically closes the review after the commit. There is a commit log template you can install. See https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-getting-started.

Hey Joe,

Thanks for bringing this up. I’ve read the committers guide a few times now and I always intend to add the metadata upon commit.

The problem is, I always commit in my local branch without the metadata tags. When it comes time to upstream that change, I get so cautious about pushing the right branch that I forget to add the metadata. It has happened twice now :(

I think I’m just going to need to force myself to add the metadata as soon as I publish the Phab review so I don’t forget in the future. Sorry!