We now build with Smithay client-toolkit v0.16.1, so patch-sctk should not be needed.
Changelog: https://github.com/aome510/spotify-player/releases
Differential D42640
audio/spotify-player: Update to v0.15.2 jfree on Nov 16 2023, 8:17 PM. Authored by Tags None Referenced Files
Subscribers None
Details We now build with Smithay client-toolkit v0.16.1, so patch-sctk should not be needed. Changelog: https://github.com/aome510/spotify-player/releases
Diff Detail
Event TimelineComment Actions Good to see this made it into the tree. The Committer's Guide describes helpful metadata, such as Approved by: and Differential Revision: to include in your commit logs. See https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer. Differential Revision: is helpful to refer a commit to review, and it also automatically closes the review after the commit. There is a commit log template you can install. See https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-getting-started. Comment Actions Hey Joe, Thanks for bringing this up. I’ve read the committers guide a few times now and I always intend to add the metadata upon commit. The problem is, I always commit in my local branch without the metadata tags. When it comes time to upstream that change, I get so cautious about pushing the right branch that I forget to add the metadata. It has happened twice now :( I think I’m just going to need to force myself to add the metadata as soon as I publish the Phab review so I don’t forget in the future. Sorry! |