Page MenuHomeFreeBSD
Differential D42590

devel/freebsd-gcc{9,12}: Various cleanups, no functional change
ClosedPublic
Actions

Authored by jhb on Nov 13 2023, 11:22 PM.
Tags
None
Referenced Files
F132146540: D42590.id130398.diff
Tue, Oct 14, 4:34 AM
F132146483: D42590.id.diff
Tue, Oct 14, 4:33 AM
F132146480: D42590.id130063.diff
Tue, Oct 14, 4:33 AM
Unknown Object (File)
Mon, Oct 13, 3:08 PM
Unknown Object (File)
Mon, Oct 13, 5:36 AM
Unknown Object (File)
Sun, Oct 5, 4:06 AM
Unknown Object (File)
Fri, Oct 3, 3:18 PM
Unknown Object (File)
Thu, Oct 2, 4:37 PM
View All 84 Files
Subscribers
emaste

Details

Reviewers
fuz
Commits
R11:5723f9adab52: devel/freebsd-gcc{9,12}: Various cleanups, no functional change
Summary
  • Use DISTVERSION instead of PORTVERISON
  • Don't silence post-install commands to remove various files from the staging area
  • Simplify logic to handle arch-specific packing lists

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 13 2023, 11:22 PM
jhb created this revision.
Harbormaster completed remote builds in B54414: Diff 130063.Nov 13 2023, 11:22 PM
jhb added a comment.Nov 13 2023, 11:23 PM

Various changes inspired from the review of adding devel/freebsd-gcc13 in D42574.

jhb mentioned this in D42574: devel/freebsd-gcc13: External FreeBSD toolchain based on GCC 13..Nov 13 2023, 11:24 PM
jhb added a reviewer: fuz.Nov 14 2023, 12:45 AM
fuz accepted this revision.Nov 14 2023, 1:32 AM

LGTM as is, but see suggested improvement.

devel/freebsd-gcc12/Makefile
111–118

Perhaps?

This revision is now accepted and ready to land.Nov 14 2023, 1:32 AM
emaste added a subscriber: emaste.Nov 14 2023, 1:37 AM
jhb updated this revision to Diff 130283.Nov 17 2023, 10:22 PM

Additional fixes

This revision now requires review to proceed.Nov 17 2023, 10:22 PM
Harbormaster completed remote builds in B54502: Diff 130283.Nov 17 2023, 10:22 PM
fuz accepted this revision.Nov 19 2023, 10:30 PM

LGTM, but perhaps you could mention explicitly that it's for compiling the same FreeBSD version the host runs.

This revision is now accepted and ready to land.Nov 19 2023, 10:30 PM
Closed by commit R11:5723f9adab52: devel/freebsd-gcc{9,12}: Various cleanups, no functional change (authored by jhb). · Explain WhyNov 21 2023, 9:46 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: R11:5723f9adab52: devel/freebsd-gcc{9,12}: Various cleanups, no functional change.

Revision Contents
Changeset List

PathSize
devel/
freebsd-gcc12/
33 lines
4 lines
pkg-plist.riscv64
pkg-plist.riscv
freebsd-gcc9/
37 lines
4 lines
pkg-plist.riscv64
pkg-plist.riscv

Diff 130398

View Options

devel/freebsd-gcc12/Makefile

Loading...
View Options

devel/freebsd-gcc12/pkg-descr

Loading...
View Options

devel/freebsd-gcc12/pkg-plist.riscv

Loading...
View Options

devel/freebsd-gcc12/pkg-plist.riscv64

Loading...
View Options

devel/freebsd-gcc9/Makefile

Loading...
View Options

devel/freebsd-gcc9/pkg-descr

Loading...
View Options

devel/freebsd-gcc9/pkg-plist.riscv

Loading...
View Options

devel/freebsd-gcc9/pkg-plist.riscv64

Loading...