urtwn(4): rework ROM reading
ClosedPublic
Actions

Authored by avos on Nov 22 2015, 7:42 PM.

Details

Reviewers

kevlo
adrian

Commits

rS291264: urtwn(4): rework ROM reading.

Summary

Add error handling for urtwn_(r88e)_read_rom() and urtwn_efuse_*() functions.
Remove code duplication between urtwn_efuse_read() and urtwn_r88e_read_rom().
Merge r88e_rom and (r92c_)rom structures (only one of them can be used at the same time).
Other minor fixes / improvements.

Test Plan

Tested with RTL8188EU (URTWN_DEBUG + USB_DEBUG, hw.usb.urtwn.debug=3, no visual differences), STA mode.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 10426.Nov 22 2015, 7:42 PM

avos retitled this revision from to urtwn(4): rework ROM reading.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptNov 22 2015, 7:42 PM

Looks fine to me. Go for it!

This revision is now accepted and ready to land.Nov 23 2015, 5:26 PM

Merging r88e_rom and (r92c_)rom structures looks good, but the rest gets more
complicated. For example, the original function doesn't need that error
handling since the length won't exceed URTWN_EFUSE_MAX_LEN while reading
data from efuse.