Differential D42319

bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.
ClosedPublic
Actions

Authored by jhb on Oct 20 2023, 8:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 30 2024, 8:36 AM

	Unknown Object (File)
	Apr 30 2024, 8:36 AM

	Unknown Object (File)
	Apr 30 2024, 8:36 AM

	Unknown Object (File)
	Apr 30 2024, 5:08 AM

	Unknown Object (File)
	Mar 14 2024, 8:33 PM

	Unknown Object (File)
	Mar 12 2024, 6:12 PM

	Unknown Object (File)
	Mar 12 2024, 1:41 PM

	Unknown Object (File)
	Mar 12 2024, 1:40 PM

View All 18 Files

Subscribers

Details

Reviewers: None
Commits: rGa463db46a11c: bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.
rG904ebc903cbe: bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.
rGde82aed11924: bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.

Summary

Only set a default value of 1 if the shell variable is unset. This allows
installer scripts to disable the variable.

PR: 274513

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 20 2023, 8:35 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptOct 20 2023, 8:35 PM

jhb requested review of this revision.Oct 20 2023, 8:35 PM

Harbormaster completed remote builds in B54117: Diff 129177.Oct 20 2023, 8:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2023, 7:21 PM

Closed by commit rGde82aed11924: bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGde82aed11924: bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null..

jhb added a commit: rG904ebc903cbe: bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null..Jan 3 2024, 8:33 PM

jhb added a commit: rGa463db46a11c: bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null..Jan 5 2024, 12:26 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

scripts/

2 lines

Diff 130302

usr.sbin/bsdinstall/scripts/zfsboot

Loading...