Page MenuHomeFreeBSD

x11/xdm: Use $LOCALBASE/etc/xdm/Xservers as base for Xserver args
ClosedPublic

Authored by cy on Oct 5 2023, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 1:31 AM
Unknown Object (File)
Thu, Oct 9, 10:15 PM
Unknown Object (File)
Thu, Oct 9, 7:17 PM
Unknown Object (File)
Wed, Oct 8, 5:27 PM
Unknown Object (File)
Wed, Oct 8, 4:20 AM
Unknown Object (File)
Thu, Oct 2, 6:10 PM
Unknown Object (File)
Thu, Oct 2, 9:38 AM
Unknown Object (File)
Sat, Sep 20, 1:40 AM
Subscribers
None

Details

Summary

Hard coding Xserver args forces people to invoke xdm through init
by placing an entry in /etc/ttys when Xserver args different from
those hardcoded in rc.d/xdm are desired. Instead glean arguments
from $LOCALBASE/etc/xdm/Xservers, defaulting to the hardcoded
entry if none are found for :0.

Test Plan

Tested and working here.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cy requested review of this revision.Oct 5 2023, 9:24 PM
cy created this revision.
This revision is now accepted and ready to land.Oct 6 2023, 5:32 AM

The original patch didn't take into account that a user might change the DisplayManager.servers resource to point to different file from the default file. The DisplayManager.servers resource could also be set to a string (just like -servers sets the resource), meaning it may not be a file. xdm will assume it's a file if the string begins with a slash ("/"). We need to take this also into account.

Again, this has been tested and is currently running here.

This revision now requires review to proceed.Oct 9 2023, 4:52 AM
This revision is now accepted and ready to land.Oct 9 2023, 5:24 AM