security/xray-core: Update to 1.8.4

[jbo]

Summary

Changelogs:

1.8.4: https://github.com/XTLS/Xray-core/releases/tag/v1.8.4
1.8.3: https://github.com/XTLS/Xray-core/releases/tag/v1.8.3
1.8.1: https://github.com/XTLS/Xray-core/releases/tag/v1.8.1
1.8.0: https://github.com/XTLS/Xray-core/releases/tag/v1.8.0

[jbo]

Add PR reference to commit message.

[jbo]

I asked the submitter about the removal of the rc.d script:

rc.d script is not from upstream. I created it as a part of 1.7.5 update. Script still exists and being installed with the port. It is templatized and located in files/xray.in

I accidentally added it to pkg-list in previous version while it is not required based on my understanding of template system. I clearly see rc.d templated scripts not to be part of pkg-list in other ports. I validated the port still installs/removes script properly without any errors.

[zirias]

security/xray-core/Makefile

37–38

Are these files really needed for the build or could we install them directly from DISTDIR in post-install?

[jbo]

Remove seemingly unnecessary copy of *.dat files during build.

[jbo]

Currently waiting on submitter feedback whether this change is okay.

security/xray-core/Makefile

37–38

Good point. I ran some test builds without this and they seem to succeed just fine.

[jbo]

Submitter responded that this is okay.

[zirias]