Page MenuHomeFreeBSD

misc/retry: Add new port
ClosedPublic

Authored by jbo on Sep 14 2023, 4:02 PM.
Tags
None
Referenced Files
F133013065: D41862.id.diff
Wed, Oct 22, 1:45 AM
F133013061: D41862.id127417.diff
Wed, Oct 22, 1:45 AM
F133013051: D41862.id127422.diff
Wed, Oct 22, 1:45 AM
F132961420: D41862.diff
Tue, Oct 21, 2:10 PM
Unknown Object (File)
Thu, Oct 16, 3:35 AM
Unknown Object (File)
Tue, Oct 14, 8:53 AM
Unknown Object (File)
Sun, Oct 12, 5:19 PM
Unknown Object (File)
Wed, Oct 8, 5:38 PM
Subscribers

Details

Summary

A utility to retry a command until the command succeeds

PR: 273730

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbo requested review of this revision.Sep 14 2023, 4:02 PM
diizzy added inline comments.
misc/retry/Makefile
11

Please also define LICENSE_FILE

13

There's a man page in the tarball already?

15

Is autoreconf really needed?

17

You probably want GNU_CONFIGURE here as it's not a custom configure script

Thanks @diizzy, agree with everything. Just to clarify, some of these seem to be remains from a first version of the patch in the PR that used USE_GITHUB although there is a proper distfile ;)

Update Makefile as requested.

However, unless I am being blind, the distfile does not include
a license file suitable for LICENSE_FILE?

jbo marked 4 inline comments as done.

Found the license file... sorry for the noise :D

This revision is now accepted and ready to land.Sep 15 2023, 1:12 PM
This revision was automatically updated to reflect the committed changes.