Paths

Table of Contentst

Differential D41862

misc/retry: Add new port
ClosedPublic
Actions

Authored by jbo on Sep 14 2023, 4:02 PM.

Tags

None

Referenced Files

	F133013065: D41862.id.diff
	Wed, Oct 22, 1:45 AM

	F133013061: D41862.id127417.diff
	Wed, Oct 22, 1:45 AM

	F133013051: D41862.id127422.diff
	Wed, Oct 22, 1:45 AM

	F132961420: D41862.diff
	Tue, Oct 21, 2:10 PM

	Unknown Object (File)
	Thu, Oct 16, 3:35 AM

	Unknown Object (File)
	Tue, Oct 14, 8:53 AM

	Unknown Object (File)
	Sun, Oct 12, 5:19 PM

	Unknown Object (File)
	Wed, Oct 8, 5:38 PM

Subscribers

Details

Reviewers

tcberner
zirias

Commits

R11:c046a1681579: misc/retry: Add new port

Summary

A utility to retry a command until the command succeeds

PR: 273730

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jbo created this revision.Sep 14 2023, 4:02 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 14 2023, 4:02 PM

jbo requested review of this revision.Sep 14 2023, 4:02 PM

Harbormaster completed remote builds in B53588: Diff 127392.Sep 14 2023, 4:02 PM

diizzy added a subscriber: diizzy.Sep 14 2023, 5:23 PM

diizzy added inline comments.

misc/retry/Makefile
11	Please also define LICENSE_FILE
13	There's a man page in the tarball already?
15	Is autoreconf really needed?
17	You probably want GNU_CONFIGURE here as it's not a custom configure script

Thanks @diizzy, agree with everything. Just to clarify, some of these seem to be remains from a first version of the patch in the PR that used USE_GITHUB although there is a proper distfile ;)

Update Makefile as requested.

However, unless I am being blind, the distfile does not include
a license file suitable for LICENSE_FILE?

Harbormaster completed remote builds in B53596: Diff 127416.Sep 15 2023, 12:28 PM

Found the license file... sorry for the noise :D

Harbormaster completed remote builds in B53597: Diff 127417.Sep 15 2023, 12:29 PM

lgtm

This revision is now accepted and ready to land.Sep 15 2023, 1:12 PM

Closed by commit R11:c046a1681579: misc/retry: Add new port (authored by Jon Stuart <freebsd@zikomo.xyz>, committed by jbo). · Explain WhySep 15 2023, 1:52 PM

This revision was automatically updated to reflect the committed changes.

jbo added a commit: R11:c046a1681579: misc/retry: Add new port.

Revision Contents
Changeset List

Path

Size

misc/

1 line

retry/

20 lines

3 lines

8 lines

Diff 127422

misc/Makefile

Loading...

misc/retry/Makefile

Loading...

misc/retry/distinfo

Loading...

misc/retry/pkg-descr

Loading...