strcspn_test.c: extend tests to catch previous bug
ClosedPublic
Actions

Authored by fuz on Sep 12 2023, 3:43 AM.

Details

Reviewers

mjg
imp

Commits

rGefbccec3e072: lib/libc/tests/string/strcspn_test.c: extend tests to catch previous bug
rG601fd768cfd5: lib/libc/tests/string/strcspn_test.c: extend tests to catch previous bug

Summary

This extends the strcspn() unit tests to catch mistakes in the
implementation that only appear when a mismatch occurs in a certain
position of the string against a certain position of the set, i.e.
the bug fixed in 52d4a4d4e0dedc72bc33082a3f84c2d0fd6f2cbb.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fuz requested review of this revision.Sep 12 2023, 3:43 AM

fuz created this revision.

Harbormaster completed remote builds in B53537: Diff 127262.Sep 12 2023, 3:43 AM

Seems good to me, but why the ifdef?

lib/libc/tests/string/strcspn_test.c
151	Why the ifdef?
166	Can't tell if this is >80 characters. Either way, though, I'd be tempted to make this a standard multi-line comment as described in style(9).
185	Need 128? If so don't forget to bump the buffer size

fuz planned changes to this revision.Sep 12 2023, 5:01 AM

fuz added inline comments.

lib/libc/tests/string/strcspn_test.c
151	Tests both for `strspn` and `strcspn` are generated from the same file. This test doesn't make sense for `strspn` as `strspn` looks for mismatches, not matches. Therefore, it's enabled for `strcspn` only.
166	Just under 80 characters. I'll make it a multi-line comment for you.
185	Have added 128 for the buffer size. Set size doesn't need to be tested as we already go to the fallback slow-path with 33 character sets.