Page MenuHomeFreeBSD

Stay with WARNS=5 but do not error for -Wmissing-prototypes.
AbandonedPublic

Authored by delphij on Sep 3 2023, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 14 2024, 11:15 PM
Unknown Object (File)
May 9 2024, 4:34 PM
Unknown Object (File)
May 7 2024, 8:19 AM
Unknown Object (File)
Apr 9 2024, 12:09 PM
Unknown Object (File)
Mar 6 2024, 9:55 AM
Unknown Object (File)
Dec 22 2023, 10:30 PM
Unknown Object (File)
Dec 12 2023, 6:43 AM
Unknown Object (File)
Nov 18 2023, 6:22 AM
Subscribers

Details

Reviewers
jrtc27

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53421
Build 50312: arc lint + arc unit

Event Timeline

Thanks; LGTM assuming it builds

This revision is now accepted and ready to land.Sep 3 2023, 9:40 PM
usr.bin/minigzip/Makefile
9

Hm, or maybe just -Wno-missing-prototypes?

delphij added inline comments.
usr.bin/minigzip/Makefile
9

That won't work because -Wmissing-prototypes is introduced in bsd.prog.mk (via bsd.sys.mk), so effectively it would be -Wno-missing-prototypes -Wmissing-prototypes and the latter wins.

(The alternative would be to move the CWARNFLAGS under bsd.prog.mk but that would be rather ugly...)

usr.bin/minigzip/Makefile
9

That's what tools/regression/fsx/Makefile does. The alternative is to use CWARNFLAGS.minigzip.c, which gets added after CWARNFLAGS. Or just pull in the fix from upstream now it's been merged.

delphij marked an inline comment as done.

Replaced with rGea1024f468a4 .