Page MenuHomeFreeBSD

Default MK_META_MODE per MK_DIRDEPS_BUILD
AcceptedPublic

Authored by sjg on Nov 15 2015, 2:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 9:59 AM
Unknown Object (File)
Jun 16 2023, 9:26 AM
Unknown Object (File)
Jun 3 2023, 5:20 PM
Unknown Object (File)
Apr 17 2017, 11:16 AM
Unknown Object (File)
Apr 9 2017, 7:09 PM
Unknown Object (File)
Feb 6 2017, 12:16 AM
Unknown Object (File)
Dec 31 2016, 7:26 PM
Unknown Object (File)
Dec 13 2016, 7:07 AM
Subscribers

Details

Reviewers
bdrewery
Summary

Also update to latest dirdeps.mk so we can

make -f dirdeps.mk some/dir.${MACHINE}

ie priming DIRDEPS from command line.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 1142
Build 1146: arc lint + arc unit

Event Timeline

sjg retitled this revision from to Default MK_META_MODE per MK_DIRDEPS_BUILD.
sjg updated this object.
sjg edited the test plan for this revision. (Show Details)
sjg added a reviewer: bdrewery.
share/mk/sys.mk
27

Might this conflict with something? The WITH_META_FILES was known to be "not the normal meta build" so I worry it might break the dirdeps build in weird ways now.

share/mk/sys.mk
27

I don't think so, with the new knobs I think - and therefor the idea is to consider MK_META_MODE a subset of MK_DIRDEPS_BUILD.
Very few parts of the build (outside say sys.mk) should really care about the distinction. The idea is that most places in the build could simply consider MK_META_MODE.

The idea here is that if meta mode is enabled - (via MK_META_MODE or MK_DIRDEPS_BUILD) some things can be done differently - eg. use of META_COOKIE_TOUCH

If we treat MK_META_MODE as a subset of MK_DIRDEPS_BUILD, then makefiles can simply consider MK_META_MODE.
On very rare occasions it may be necessary to check MK_META_MODE==yes and MK_DIRDEPS_BUILD==no

bdrewery edited edge metadata.

Yes this sounds good. The only place I found with a possible conflict is already handled fine (top of sys.mk).

This revision is now accepted and ready to land.Nov 16 2015, 7:32 PM