Page MenuHomeFreeBSD

Make gutenprint-cups pass QA
AbandonedPublic

Authored by martin_sugioarto.com on Nov 14 2015, 11:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 8:44 AM
Unknown Object (File)
Fri, Apr 26, 8:44 AM
Unknown Object (File)
Jan 22 2024, 2:57 AM
Unknown Object (File)
Jan 11 2024, 12:13 AM
Unknown Object (File)
Jan 1 2024, 2:24 PM
Unknown Object (File)
Dec 28 2023, 6:32 PM
Unknown Object (File)
Dec 20 2023, 12:58 AM
Unknown Object (File)
Nov 3 2023, 7:18 AM
Subscribers

Details

Reviewers
koobs
Group Reviewers
Contributor Reviewers (ports)
Summary

Fixes a shebang line in a perl script which prevented installation.

Test Plan
  • make install
  • verify that it passes qa check

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1140
Build 1144: arc lint + arc unit

Event Timeline

martin_sugioarto.com retitled this revision from to Make gutenprint-cups pass QA.
martin_sugioarto.com updated this object.
martin_sugioarto.com edited the test plan for this revision. (Show Details)
mat added inline comments.
print/gutenprint-cups/Makefile
20–21

This somehow looks wrong, there must be missing something, like maybe USES=perl5 that would add ac_cv_path_PERL=${PERL} and ac_cv_path_PERL_PATH=${PERL} to CONFIGURE_ARGS.

Add USE perl5 to gutenprint-cups

  • as suggested by @mat
koobs requested changes to this revision.Nov 18 2015, 10:10 AM
koobs added a reviewer: koobs.
koobs added a subscriber: koobs.
koobs added inline comments.
print/gutenprint-base/Makefile
30–37

Any reason these cant be put before bsd.port.options.mk, thereby removing the need for both bsd.port.options.mk and bsd.port.pre.mk ?

This revision now requires changes to proceed.Nov 18 2015, 10:10 AM

It looks like different fix to some other problem to me.

print/gutenprint-base/Makefile
30–37

I am not sure how to fix this. My intention was not to touch much of the port, just make the perl5 use flag pass from the top down to the base port.