Page MenuHomeFreeBSD

ps: Complete libxo transition.
ClosedPublic

Authored by yanhaowang on Aug 11 2023, 6:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 29, 7:05 AM
Unknown Object (File)
Sun, Nov 9, 12:45 AM
Unknown Object (File)
Fri, Nov 7, 2:14 AM
Unknown Object (File)
Thu, Nov 6, 8:58 PM
Unknown Object (File)
Nov 5 2025, 1:43 AM
Unknown Object (File)
Nov 5 2025, 1:25 AM
Unknown Object (File)
Nov 4 2025, 5:33 PM
Unknown Object (File)
Nov 4 2025, 5:30 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Remove unnecessary space line.
des requested changes to this revision.Aug 17 2023, 3:26 PM

As a general note (also regarding your other reviews), using EXIT_SUCCESS and EXIT_FAILURE instead of 0 and 1 is a matter of taste, but whichever option you choose should be applied consistently. If the program you're working on has a large number of instances of xo_err(1, ...) or xo_errx(1, ...), you'll have to decide whether to change them all to xo_err(EXIT_FAILURE, ...) or xo_errx(EXIT_FAILURE, ...) or whether to stick to 1 and 0 to reduce the magnitude of the change.

bin/ps/keyword.c
294

EXIT_FAILURE

303

EXIT_FAILURE

348

EXIT_FAILURE

This revision now requires changes to proceed.Aug 17 2023, 3:26 PM
bin/ps/ps.c
1484

There is no need for a cast here.

This revision is now accepted and ready to land.Aug 26 2023, 11:52 PM
This revision was automatically updated to reflect the committed changes.