ndp: Complete libxo transition
ClosedPublic
Actions

Authored by yanhaowang on Aug 10 2023, 11:15 PM.

Details

Reviewers

lwhsu
des

Commits

rG54ff53d89015: ndp(8): Complete libxo transition

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yanhaowang created this revision.Aug 10 2023, 11:15 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 10 2023, 11:15 PM

yanhaowang requested review of this revision.Aug 10 2023, 11:15 PM

Harbormaster completed remote builds in B53040: Diff 125848.Aug 10 2023, 11:15 PM

yanhaowang added reviewers: lwhsu, des.Aug 10 2023, 11:20 PM

Remove unnecessary space line.

Harbormaster completed remote builds in B53066: Diff 125903.Aug 12 2023, 2:21 AM

des requested changes to this revision.Aug 17 2023, 3:12 PM

des added inline comments.

usr.sbin/ndp/ndp.c
923–924	These `printf()` calls should be changed to `xo_error()`.
usr.sbin/ndp/ndp_netlink.c
43–44	Spurious blank line.

This revision now requires changes to proceed.Aug 17 2023, 3:12 PM

Using xo_err to replace printf.
Use number style.

Harbormaster completed remote builds in B53198: Diff 126292.Aug 21 2023, 12:24 PM

yanhaowang marked 2 inline comments as done.Aug 21 2023, 12:24 PM

des accepted this revision.Aug 26 2023, 11:50 PM

This revision is now accepted and ready to land.Aug 26 2023, 11:50 PM

Closed by commit rG54ff53d89015: ndp(8): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhySat, Oct 12, 6:30 PM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rG54ff53d89015: ndp(8): Complete libxo transition.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ndp/

ndp.c

20 lines

ndp_netlink.c

6 lines

Diff 144733

View Options

usr.sbin/ndp/ndp.c