udf: Reject read requests with an invalid length
ClosedPublic
Actions

Authored by jhb on Jul 27 2023, 11:05 PM.

Details

Reviewers

Commits

rG0db7f4b419db: udf: Reject read requests with an invalid length
rG202c1d762186: udf: Reject read requests with an invalid length
rGc70e615051b0: udf: Reject read requests with an invalid length

Summary

If the size is negative or if rounding it up to a multiple of the block size overflows, fail the read request with ERANGE.

While here, add a sanity check that the ICB length for the root directory is at least as long as a minimum-sized file entry.

PR: 257768
Reported by: Robert Morris <rtm@lcs.mit.edu>
Sponsored by: FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 27 2023, 11:05 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2023, 11:05 PM

jhb requested review of this revision.Jul 27 2023, 11:05 PM

Harbormaster completed remote builds in B52879: Diff 125268.Jul 27 2023, 11:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2023, 11:43 PM

Closed by commit rGc70e615051b0: udf: Reject read requests with an invalid length (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc70e615051b0: udf: Reject read requests with an invalid length.

jhb added a commit: rG202c1d762186: udf: Reject read requests with an invalid length.Sep 6 2023, 9:57 PM

jhb added a commit: rG0db7f4b419db: udf: Reject read requests with an invalid length.Sep 6 2023, 10:03 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

udf/

udf.h

4 lines

udf_vfsops.c

5 lines

Diff 125608

View Options

sys/fs/udf/udf.h