Paths

Table of Contentst

Differential D41078

Fix 1
AbandonedPublic
Actions

Authored by imp on Jul 19 2023, 2:35 AM.

Tags

None

Referenced Files

	F131643724: D41078.diff
	Fri, Oct 10, 12:03 AM

	Unknown Object (File)
	Fri, Sep 26, 1:44 PM

	Unknown Object (File)
	Thu, Sep 18, 12:06 PM

	Unknown Object (File)
	Aug 2 2025, 4:57 PM

	Unknown Object (File)
	Jul 10 2025, 10:53 AM

	Unknown Object (File)
	Jul 10 2025, 5:49 AM

	Unknown Object (File)
	Jul 8 2025, 6:13 AM

	Unknown Object (File)
	Jun 29 2025, 10:53 PM

View All 55 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52703
Build 49594: arc lint + arc unit

Event Timeline

imp created this revision.Jul 19 2023, 2:35 AM

Herald added a reviewer: cam. · View Herald TranscriptJul 19 2023, 2:35 AM

imp requested review of this revision.Jul 19 2023, 2:35 AM

Harbormaster completed remote builds in B52703: Diff 124826.Jul 19 2023, 2:35 AM

Revert c5312bd79e66ce8ef50655ce7f3eca06d6b6e24f. and then apply this.

This is for discussion only at the moment.

In this fix, we rename memdesc_ccb to cam_memdesc_ccb and make it a static inline in cam_ccb.h

imp mentioned this in D41058: cam: Move bus_dmamap_load_ccb into cam.c..Jul 19 2023, 2:38 AM

I don't feel strongly that we need to rename it. We don't call bus_dmamap_load_ccb, cam_bus_dmamap_load_ccb for example. However, the function is also a bit different now. I wonder which manpage you would want to put it in for example? Would it be some generic cam_ccb(9) or would it belong in a memdesc(9)? I can sort of see arguments both ways.

sys/cam/cam_ccb.h
1556	Maybe a blank line before the #ifdef?

OBE, I think.

Herald added a subscriber: olce. · View Herald TranscriptOct 15 2024, 4:23 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

71 lines

73 lines

kern/

2 lines

sys/

2 lines

Diff 124826

sys/cam/cam.c

Loading...

sys/cam/cam_ccb.h

Loading...

sys/kern/subr_bus_dma.c

Loading...

sys/sys/memdesc.h

Loading...