Page MenuHomeFreeBSD
Differential D41078

Fix 1
AbandonedPublic
Actions

Authored by imp on Jul 19 2023, 2:35 AM.
Tags
None
Referenced Files
F135852899: D41078.diff
Thu, Nov 13, 1:18 PM
Unknown Object (File)
Wed, Nov 5, 3:57 PM
Unknown Object (File)
Tue, Nov 4, 9:16 PM
Unknown Object (File)
Tue, Nov 4, 8:31 PM
Unknown Object (File)
Tue, Nov 4, 8:27 PM
Unknown Object (File)
Tue, Nov 4, 8:25 PM
Unknown Object (File)
Tue, Nov 4, 1:53 PM
Unknown Object (File)
Sun, Nov 2, 12:50 AM
View All 68 Files
Subscribers
jhb
olce

Details

Reviewers
None
Group Reviewers
cam

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52703
Build 49594: arc lint + arc unit

Event Timeline

imp created this revision.Jul 19 2023, 2:35 AM
Herald added a reviewer: cam. · View Herald TranscriptJul 19 2023, 2:35 AM
imp requested review of this revision.Jul 19 2023, 2:35 AM
Harbormaster completed remote builds in B52703: Diff 124826.Jul 19 2023, 2:35 AM
imp added a comment.Jul 19 2023, 2:36 AM

Revert c5312bd79e66ce8ef50655ce7f3eca06d6b6e24f. and then apply this.

This is for discussion only at the moment.

In this fix, we rename memdesc_ccb to cam_memdesc_ccb and make it a static inline in cam_ccb.h

imp mentioned this in D41058: cam: Move bus_dmamap_load_ccb into cam.c..Jul 19 2023, 2:38 AM
jhb added a subscriber: jhb.Jul 19 2023, 5:23 PM

I don't feel strongly that we need to rename it. We don't call bus_dmamap_load_ccb, cam_bus_dmamap_load_ccb for example. However, the function is also a bit different now. I wonder which manpage you would want to put it in for example? Would it be some generic cam_ccb(9) or would it belong in a memdesc(9)? I can sort of see arguments both ways.

sys/cam/cam_ccb.h
1556

Maybe a blank line before the #ifdef?

imp abandoned this revision.Oct 15 2024, 4:23 PM

OBE, I think.

Herald added a subscriber: olce. · View Herald TranscriptOct 15 2024, 4:23 PM

Revision Contents
Changeset List

PathSize
sys/
cam/
71 lines
73 lines
kern/
2 lines
sys/
2 lines

Diff 124826

View Options

sys/cam/cam.c

Loading...
View Options

sys/cam/cam_ccb.h

Loading...
View Options

sys/kern/subr_bus_dma.c

Loading...
View Options

sys/sys/memdesc.h

Loading...