Page MenuHomeFreeBSD

lang/zig-devel: NEW PORT - latest version of zig language
Needs RevisionPublic

Authored by bsd_orsolic.org on Jul 18 2023, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 6:16 AM
Unknown Object (File)
Fri, Nov 8, 6:16 AM
Unknown Object (File)
Tue, Oct 22, 3:46 AM
Unknown Object (File)
Fri, Oct 18, 7:25 AM
Unknown Object (File)
Thu, Oct 17, 1:14 PM
Unknown Object (File)
Thu, Oct 17, 2:39 AM
Unknown Object (File)
Tue, Oct 15, 1:22 PM
Unknown Object (File)
Mon, Oct 14, 5:28 PM

Details

Reviewers
dch
Group Reviewers
portmgr
Summary

This adds latest development version of zig-lang - upcoming 0.12.
Makefile was based on lang/zig Makefile and simplified.
I am using it for the fast few months for my projects.

Test Plan

Tested on 14.0-RELEASE and 15.0-CURRENT.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bsd_orsolic.org created this revision.

In ports the convention is using -devel suffix for the development snapshot.

lang/zig-dev/Makefile
2 ↗(On Diff #124800)

so the PKGNAMESUFFIX would be better to be -devel

4 ↗(On Diff #124800)

No need to set PORTREVISION when it's 0.

lang/zig-dev/files/patch-CMakeLists.txt
7 ↗(On Diff #124800)

I suggest using CMake variable or post-patch script to avoid updating this in the future.

bsd_orsolic.org marked 3 inline comments as done.

Modified according to the review comments.
Folder renamed from zig-dev to zig-devel.

Please update this revision to zig 0.12.x with LLVM 17.x and add @dch, the maintainer for lang/zig, and portmgr

bsd_orsolic.org retitled this revision from lang/zig-dev: NEW PORT - latest version of zig language to lang/zig-devel: NEW PORT - latest version of zig language.
bsd_orsolic.org edited the summary of this revision. (Show Details)
bsd_orsolic.org edited the test plan for this revision. (Show Details)
bsd_orsolic.org added a reviewer: portmgr.

Updated to latest zig 0.12.

dch requested changes to this revision.Jan 12 2024, 2:58 PM

its not easy to add a "diff of diffs" in phabricator, so here's : https://reviews.freebsd.org/D43416
which merges in lang/zig which has changed a bit, into your changes.

  • add libxml2 as build time dependency, it seems its necessary on 15.0-CURRENT at least
  • switch to static build by default to keep dependencies down
  • you used llvm17-lite flavour here I switched it back to llvm17 "the giant hog compiler"

For a ports build (to me) it makes more sense to use the default llvm17, as its more likely already
to be either built (in poudriere), or pulled in as a dependency (of other ports/pkgs). What do
you think?

If you're happy with changes I can commit it, or if you want to make other changes then let's
follow up here, rather than on my separate review.

This revision now requires changes to proceed.Jan 12 2024, 2:58 PM

I agree and I am happy with your changes.
Thanks for the review!