Page MenuHomeFreeBSD

Disable NEON on arm64
ClosedPublic

Authored by andrew on Nov 8 2015, 9:13 AM.

Details

Summary

The spexdsp NEON code is only valid for 32-bit arm, disable it on arm64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

andrew updated this revision to Diff 10021.Nov 8 2015, 9:13 AM
andrew retitled this revision from to Disable NEON on arm64.
andrew updated this object.
andrew edited the test plan for this revision. (Show Details)
andrew added reviewers: bapt, tijl.
tijl requested changes to this revision.Nov 8 2015, 11:17 AM
tijl edited edge metadata.
tijl added inline comments.
audio/speexdsp/Makefile
17 ↗(On Diff #10021)

You can include bsd.port.options.mk here and bsd.port.mk below.

20 ↗(On Diff #10021)

It's safer to use += after .include.

This revision now requires changes to proceed.Nov 8 2015, 11:17 AM
andrew updated this revision to Diff 10025.Nov 8 2015, 11:42 AM
andrew edited edge metadata.

Update to use new include and +=

andrew updated this object.Nov 8 2015, 11:42 AM
andrew edited edge metadata.
tijl accepted this revision.Nov 8 2015, 11:53 AM
tijl edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2015, 11:53 AM
This revision was automatically updated to reflect the committed changes.