Page MenuHomeFreeBSD
Differential D40879

libc: Improve setjmp comments
ClosedPublic
Actions

Authored by dchagin on Jul 5 2023, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 1:23 PM
Unknown Object (File)
Feb 6 2025, 9:19 AM
Unknown Object (File)
Feb 6 2025, 8:51 AM
Unknown Object (File)
Feb 3 2025, 12:39 AM
Unknown Object (File)
Jan 30 2025, 6:11 AM
Unknown Object (File)
Sep 24 2024, 4:44 AM
Unknown Object (File)
Sep 20 2024, 6:24 AM
Unknown Object (File)
Sep 19 2024, 6:06 AM
View All 39 Files
Subscribers
imp

Details

Reviewers
kib
imp
Commits
rGacfd26152424: libc: Improve setjmp comments

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Jul 5 2023, 10:41 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 5 2023, 10:41 PM
dchagin requested review of this revision.Jul 5 2023, 10:41 PM
Harbormaster completed remote builds in B52442: Diff 124204.Jul 5 2023, 10:42 PM
dchagin added a reviewer: kib.Jul 5 2023, 10:50 PM
imp accepted this revision.Jul 5 2023, 11:49 PM

These match what I'd expect, but kib is the final authority

This revision is now accepted and ready to land.Jul 5 2023, 11:49 PM
kib accepted this revision.Jul 6 2023, 12:12 AM
Closed by commit rGacfd26152424: libc: Improve setjmp comments (authored by dchagin). · Explain WhyJul 6 2023, 5:22 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGacfd26152424: libc: Improve setjmp comments.

Revision Contents
Changeset List

PathSize
lib/
libc/
amd64/
gen/
6 lines
6 lines
6 lines

Diff 124238

View Options

lib/libc/amd64/gen/_setjmp.S

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
static int static int
_gethostbynis(const char *name, char *map, int af, struct hostent *he, _gethostbynis(const char *name, char *map, int af, struct hostent *he,
struct hostent_data *hed) struct hostent_data *hed)
{ {
char *p, *bp, *ep; char *p, *bp, *ep;
char *cp, **q; char *cp, **q;
char *result; char *result;
int resultlen, size, addrok = 0; int resultlen, size, addrok = 0;
char ypbuf[YPMAXRECORD + 2]; char *ypbuf;
res_state statp; res_state statp;
statp = __res_state(); statp = __res_state();
switch(af) { switch(af) {
case AF_INET: case AF_INET:
size = NS_INADDRSZ; size = NS_INADDRSZ;
break; break;
case AF_INET6: case AF_INET6:
Show All 13 Lines_gethostbynis(const char *name, char *map, int af, struct hostent *he,
if (yp_match(hed->yp_domain, map, name, strlen(name), &result, if (yp_match(hed->yp_domain, map, name, strlen(name), &result,
&resultlen)) { &resultlen)) {
RES_SET_H_ERRNO(statp, HOST_NOT_FOUND); RES_SET_H_ERRNO(statp, HOST_NOT_FOUND);
return (-1); return (-1);
} }
/* avoid potential memory leak */ /* avoid potential memory leak */
bcopy((char *)result, (char *)&ypbuf, resultlen); ypbuf = alloca(resultlen + 2);
bcopy(result, ypbuf, resultlen);
ypbuf[resultlen] = '\0'; ypbuf[resultlen] = '\0';
free(result); free(result);
result = (char *)&ypbuf; result = ypbuf;
if ((cp = strchr(result, '\n'))) if ((cp = strchr(result, '\n')))
*cp = '\0'; *cp = '\0';
cp = strpbrk(result, " \t"); cp = strpbrk(result, " \t");
*cp++ = '\0'; *cp++ = '\0';
he->h_addr_list = hed->h_addr_ptrs; he->h_addr_list = hed->h_addr_ptrs;
he->h_addr = (char *)hed->host_addr; he->h_addr = (char *)hed->host_addr;
▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines
View Options

lib/libc/amd64/gen/setjmp.S

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
static int static int
_gethostbynis(const char *name, char *map, int af, struct hostent *he, _gethostbynis(const char *name, char *map, int af, struct hostent *he,
struct hostent_data *hed) struct hostent_data *hed)
{ {
char *p, *bp, *ep; char *p, *bp, *ep;
char *cp, **q; char *cp, **q;
char *result; char *result;
int resultlen, size, addrok = 0; int resultlen, size, addrok = 0;
char ypbuf[YPMAXRECORD + 2]; char *ypbuf;
res_state statp; res_state statp;
statp = __res_state(); statp = __res_state();
switch(af) { switch(af) {
case AF_INET: case AF_INET:
size = NS_INADDRSZ; size = NS_INADDRSZ;
break; break;
case AF_INET6: case AF_INET6:
Show All 13 Lines_gethostbynis(const char *name, char *map, int af, struct hostent *he,
if (yp_match(hed->yp_domain, map, name, strlen(name), &result, if (yp_match(hed->yp_domain, map, name, strlen(name), &result,
&resultlen)) { &resultlen)) {
RES_SET_H_ERRNO(statp, HOST_NOT_FOUND); RES_SET_H_ERRNO(statp, HOST_NOT_FOUND);
return (-1); return (-1);
} }
/* avoid potential memory leak */ /* avoid potential memory leak */
bcopy((char *)result, (char *)&ypbuf, resultlen); ypbuf = alloca(resultlen + 2);
bcopy(result, ypbuf, resultlen);
ypbuf[resultlen] = '\0'; ypbuf[resultlen] = '\0';
free(result); free(result);
result = (char *)&ypbuf; result = ypbuf;
if ((cp = strchr(result, '\n'))) if ((cp = strchr(result, '\n')))
*cp = '\0'; *cp = '\0';
cp = strpbrk(result, " \t"); cp = strpbrk(result, " \t");
*cp++ = '\0'; *cp++ = '\0';
he->h_addr_list = hed->h_addr_ptrs; he->h_addr_list = hed->h_addr_ptrs;
he->h_addr = (char *)hed->host_addr; he->h_addr = (char *)hed->host_addr;
▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines
View Options

lib/libc/amd64/gen/sigsetjmp.S

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
static int static int
_gethostbynis(const char *name, char *map, int af, struct hostent *he, _gethostbynis(const char *name, char *map, int af, struct hostent *he,
struct hostent_data *hed) struct hostent_data *hed)
{ {
char *p, *bp, *ep; char *p, *bp, *ep;
char *cp, **q; char *cp, **q;
char *result; char *result;
int resultlen, size, addrok = 0; int resultlen, size, addrok = 0;
char ypbuf[YPMAXRECORD + 2]; char *ypbuf;
res_state statp; res_state statp;
statp = __res_state(); statp = __res_state();
switch(af) { switch(af) {
case AF_INET: case AF_INET:
size = NS_INADDRSZ; size = NS_INADDRSZ;
break; break;
case AF_INET6: case AF_INET6:
Show All 13 Lines_gethostbynis(const char *name, char *map, int af, struct hostent *he,
if (yp_match(hed->yp_domain, map, name, strlen(name), &result, if (yp_match(hed->yp_domain, map, name, strlen(name), &result,
&resultlen)) { &resultlen)) {
RES_SET_H_ERRNO(statp, HOST_NOT_FOUND); RES_SET_H_ERRNO(statp, HOST_NOT_FOUND);
return (-1); return (-1);
} }
/* avoid potential memory leak */ /* avoid potential memory leak */
bcopy((char *)result, (char *)&ypbuf, resultlen); ypbuf = alloca(resultlen + 2);
bcopy(result, ypbuf, resultlen);
ypbuf[resultlen] = '\0'; ypbuf[resultlen] = '\0';
free(result); free(result);
result = (char *)&ypbuf; result = ypbuf;
if ((cp = strchr(result, '\n'))) if ((cp = strchr(result, '\n')))
*cp = '\0'; *cp = '\0';
cp = strpbrk(result, " \t"); cp = strpbrk(result, " \t");
*cp++ = '\0'; *cp++ = '\0';
he->h_addr_list = hed->h_addr_ptrs; he->h_addr_list = hed->h_addr_ptrs;
he->h_addr = (char *)hed->host_addr; he->h_addr = (char *)hed->host_addr;
▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines