Page MenuHomeFreeBSD
Differential D40832

divmoddi4: Handle negative remainders.
ClosedPublic
Actions

Authored by jhb on Jul 1 2023, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 5, 12:50 PM
Unknown Object (File)
Mon, Oct 5, 12:43 PM
Unknown Object (File)
Mon, Oct 5, 12:21 PM
Unknown Object (File)
Thu, Sep 24, 5:27 AM
Unknown Object (File)
Thu, Sep 17, 9:59 PM
Unknown Object (File)
Sun, Sep 13, 9:27 AM
Unknown Object (File)
Fri, Sep 11, 2:35 PM
Unknown Object (File)
Thu, Sep 10, 9:30 PM
View All Files
Subscribers
imp

Details

Reviewers
jrtc27
Commits
rGdf11fb9bf042: divmoddi4: Handle negative remainders.
Summary

The sign of the remainder matches the sign of the numerator in C.

Reported by: jrtc27

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jul 1 2023, 9:32 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 1 2023, 9:32 PM
jhb requested review of this revision.Jul 1 2023, 9:32 PM
Harbormaster completed remote builds in B52376: Diff 124080.Jul 1 2023, 9:32 PM
jrtc27 accepted this revision.Jul 1 2023, 9:35 PM

negq = negr = [01] is slightly shorter and what I did but eh, debatable which is clearer

This revision is now accepted and ready to land.Jul 1 2023, 9:35 PM
jrtc27 added inline comments.Jul 1 2023, 9:36 PM
sys/libkern/divmoddi4.c
58–59
Closed by commit rGdf11fb9bf042: divmoddi4: Handle negative remainders. (authored by jhb). · Explain WhyJul 1 2023, 9:45 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGdf11fb9bf042: divmoddi4: Handle negative remainders..

Revision Contents
Changeset List

PathSize
sys/
libkern/
12 lines

Diff 124084

View Options

sys/libkern/divmoddi4.c

Loading...