Page MenuHomeFreeBSD

ena: Fix driver unload crash
Needs ReviewPublic

Authored by akiyano_amazon.com on Jun 27 2023, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 30 2024, 12:21 PM
Unknown Object (File)
Oct 18 2024, 7:20 AM
Unknown Object (File)
Oct 3 2024, 4:31 PM
Unknown Object (File)
Oct 3 2024, 2:17 PM
Unknown Object (File)
Oct 3 2024, 8:57 AM
Unknown Object (File)
Oct 3 2024, 4:11 AM
Unknown Object (File)
Oct 2 2024, 9:17 PM
Unknown Object (File)
Oct 2 2024, 9:03 PM
Subscribers

Details

Reviewers
mw
Summary

When ena_detach is called, we first call ether_ifdetach(),
which destroys internal addresses of ifp. One such address
is ifp->if_addr->ifa_addr. Then during ena_destroy_device(),
if_link_state_change() is called, eventually trying to access
ifp->if_addr->ifa_addr->sa_family. This causes an access
to garbage memory and crashes the kernel.

Ticket [1] was opened to the FreeBSD community to add null
check in the code of if_link_state_change().
A fix was submitted in commit [2], however it was noted
that it is our driver's responsibilty to not call
if_link_state_change() after calling ether_ifdetach().

This commit makes sure if_link_state_change() is not called
after ether_ifdetach().

[1]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270813
[2]: https://reviews.freebsd.org/D39614

Fixes: 32f63fa7f975 ("Split ENA reset routine into restore and destroy stages")
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped