Page MenuHomeFreeBSD

ena: Initialize statistics before the interface is available
Needs ReviewPublic

Authored by akiyano_amazon.com on Jun 27 2023, 8:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 21, 7:19 PM
Unknown Object (File)
Tue, May 21, 6:42 PM
Unknown Object (File)
Thu, May 2, 9:05 PM
Unknown Object (File)
Thu, May 2, 5:28 PM
Unknown Object (File)
Apr 18 2024, 4:09 PM
Unknown Object (File)
Feb 4 2024, 5:51 AM
Unknown Object (File)
Jan 30 2024, 3:50 PM
Unknown Object (File)
Dec 31 2023, 1:32 AM
Subscribers

Details

Reviewers
mw
Summary

In [1], the FBSD community exposed a bug in the fbsd/ena driver.

Bug description:

Current function call order is as follows:

  1. ena_attach()

1.1. ena_setup_ifnet()
1.1.1. Registration of ena_get_counter()
1.1.2. ether_ifattach(ifp, adapter->mac_addr);
1.2. Statistics allocation and initialization.

At point 1.1.2, when ether_ifattach() returns, the interface is available,
and stats can be read before they are allocated, leading to kernel panic.

Also fixed a potential memory leak by freeing the stats since they were
not freed in case the following calls failed.

Fix:

This commit moves the statistics allocation and initialization to happen
before ena_setup_ifnet()

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268934

Fixes: 9b8d05b8ac78 ("Add support for Amazon Elastic Network Adapter (ENA) NIC")
Fixes: 30217e2dff10 ("Rework counting of hardware statistics in ENA driver")
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped