Page MenuHomeFreeBSD

mrsas: Use mrsas_sge64 instead of iovec for the S/G list for passthru.
ClosedPublic

Authored by jhb on Jun 23 2023, 5:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 9:07 PM
Unknown Object (File)
Tue, Oct 14, 9:07 PM
Unknown Object (File)
Tue, Oct 14, 9:07 PM
Unknown Object (File)
Tue, Oct 14, 11:31 AM
Unknown Object (File)
Thu, Oct 9, 9:27 PM
Unknown Object (File)
Thu, Oct 9, 1:49 AM
Unknown Object (File)
Sep 13 2025, 5:09 PM
Unknown Object (File)
Sep 12 2025, 4:43 PM
Subscribers

Details

Summary

The DMA scatter/gather list for mrsas passthrough ioctl commands is
stored in a SGL at the end of the DCMD frame. Given the SGL member at
the end of the DCMD frame it seems likely this S/G list is formatted
as a fixed-width structure such as the type mrsas_sge64 and not as a
iovec which contains a kernel pointer and length that vary with the
native architecture size.

Obtained from: CheriBSD
Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jun 23 2023, 5:13 PM

I think this is right, based on what I'd expect and peeking at the driver, but I have no docs to confirm that. The structures are the same (type pun to the same thing), so it should be OK.
Plus this looks to fix a bug on big endian machines if I'm reading correctly.

This revision is now accepted and ready to land.Jun 24 2023, 6:57 PM