mrsas: Use mrsas_sge64 instead of iovec for the S/G list for passthru.
ClosedPublic
Actions

Authored by jhb on Jun 23 2023, 5:13 PM.

Details

Reviewers

ambrisko
imp

Commits

rG78cb8841f085: mrsas: Use mrsas_sge64 instead of iovec for the S/G list for passthru.

Summary

The DMA scatter/gather list for mrsas passthrough ioctl commands is
stored in a SGL at the end of the DCMD frame. Given the SGL member at
the end of the DCMD frame it seems likely this S/G list is formatted
as a fixed-width structure such as the type mrsas_sge64 and not as a
iovec which contains a kernel pointer and length that vary with the
native architecture size.

Obtained from: CheriBSD
Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 23 2023, 5:13 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 23 2023, 5:13 PM

jhb requested review of this revision.Jun 23 2023, 5:13 PM

Harbormaster completed remote builds in B52261: Diff 123688.Jun 23 2023, 5:13 PM

I think this is right, based on what I'd expect and peeking at the driver, but I have no docs to confirm that. The structures are the same (type pun to the same thing), so it should be OK.
Plus this looks to fix a bug on big endian machines if I'm reading correctly.

This revision is now accepted and ready to land.Jun 24 2023, 6:57 PM

Closed by commit rG78cb8841f085: mrsas: Use mrsas_sge64 instead of iovec for the S/G list for passthru. (authored by jhb). · Explain WhyJun 28 2023, 6:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG78cb8841f085: mrsas: Use mrsas_sge64 instead of iovec for the S/G list for passthru..