Page MenuHomeFreeBSD

www/py-django-contrib-comments: Use Django 1.6 for RUN_DEPENDS
ClosedPublic

Authored by koobs on Oct 31 2015, 8:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 6:19 PM
Unknown Object (File)
Wed, Apr 24, 5:55 PM
Unknown Object (File)
Tue, Apr 9, 3:09 AM
Unknown Object (File)
Tue, Apr 9, 3:09 AM
Unknown Object (File)
Tue, Apr 9, 12:48 AM
Unknown Object (File)
Fri, Apr 5, 12:49 PM
Unknown Object (File)
Thu, Apr 4, 3:34 PM
Unknown Object (File)
Wed, Apr 3, 4:00 PM
Subscribers

Details

Summary

Default to using Django 1.6 (www/py-django16) because the current version
of www/py-django-mezzanine does not support anything later than 1.6, and
installation currently causes a conflict as installation of both django16
and django18 are attempted:

  • py-django-mezzanine -> www/django16, www/py-django-contrib-comments
  • py-django-contrib-comments -> www/django (1.8)

This fixes a new failure in 2015Q4 reported by pkg-fallout.

This is the least of all current evils, without having to update Mezzanine
to it's latest versions (*and* have to MFH that update). It has zero impact
on other ports as mezzanine is the only port that currently consumes/depends
on it.

While I'm here, switch back to file-based dependency declaration because
django* matches all django packages, and we can't anchor using $, resulting
in `pkg info "$1" potentially returning multiple matches.

Scripts/do-depends.sh should probably check for multiple results
and error out if there is.

MFH: 2015Q4
DiffRev: <url>

Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

koobs retitled this revision from to www/py-django-contrib-comments: Use Django 1.6 for RUN_DEPENDS.
koobs updated this object.
koobs edited the test plan for this revision. (Show Details)
koobs added a reviewer: antoine.
koobs added a subscriber: portmgr.
mat added inline comments.
www/py-django-contrib-comments/Makefile
17 ↗(On Diff #9840)

Should be >=1.6<1.7

Also, 2014Q4 feels so last year.

www/py-django-contrib-comments/Makefile
17 ↗(On Diff #9840)

The commit log states that Mezzanine needs < 1.7, not django-contrib-comments (>=1.6) which this change is for

koobs removed a subscriber: portmgr.
www/py-django-contrib-comments/Makefile
17 ↗(On Diff #9840)

Hmm, django* matches all django packages, and we can't anchor using $, resulting in `pkg info "$1" potentially returning multiple matches, with the last one winning in terms of the version comparison.

So this isn't going to work and I'm going to have to switch it back to file based (django-admin.py)

Scripts/do-depends.sh should probably check for multiple results and error out if there is. cc @portmgr - I'll create an issue if you agree

Switch back to file-baed dependency declaration

This revision is now accepted and ready to land.Oct 31 2015, 10:39 AM
This revision was automatically updated to reflect the committed changes.
koobs edited edge metadata.