Page MenuHomeFreeBSD

enabling Hyper-V SMP for ARM64
Needs ReviewPublic

Authored by schakrabarti_microsoft.com on Fri, May 26, 9:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 29, 9:10 AM
Unknown Object (File)
Sat, May 27, 7:21 PM
Unknown Object (File)
Sat, May 27, 4:43 PM
Unknown Object (File)
Fri, May 26, 3:26 PM
Unknown Object (File)
Fri, May 26, 10:10 AM
Unknown Object (File)
Fri, May 26, 10:01 AM
Unknown Object (File)
Fri, May 26, 9:51 AM
Subscribers
None

Details

Reviewers
whu
kevans
Summary

vmbus_synic_setup(), is invoked via vmbus_intrhook -> vmbus_doattach -> smp_rendezvous. On !EARLY_AP_STARTUP (e.g., aarch64), SMP isn't functional in intrhooks and smp_rendezvous() will just call vmbus_synic_setup() on the boot AP. There's nothing that will initialize the pcpu data on every other AP.
To fix it we need to use SI_SUB_SMP for vmbus_doattach().

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sys/dev/hyperv/vmbus/vmbus.c
1534

This code should just go away entirely, there is no !EARLY_AP_STARTUP platform where it will ever call vmbus_doattach here.

1586

There's a reference to cold down here in the sysinit that should also go away, we should just always call vmbus_doattach() if we're doing the sysinit -- it *has* to be positioned at a point where "thread scheduling is possible".

schakrabarti_microsoft.com marked an inline comment as done.
schakrabarti_microsoft.com marked an inline comment as done.