Page MenuHomeFreeBSD

enabling Hyper-V SMP for ARM64
ClosedPublic

Authored by schakrabarti_microsoft.com on May 26 2023, 9:17 AM.
Tags
None
Referenced Files
F132301938: D40279.id122558.diff
Wed, Oct 15, 4:51 PM
Unknown Object (File)
Thu, Oct 9, 1:25 AM
Unknown Object (File)
Wed, Oct 8, 10:34 PM
Unknown Object (File)
Wed, Sep 24, 6:43 PM
Unknown Object (File)
Fri, Sep 19, 7:49 PM
Unknown Object (File)
Sep 14 2025, 12:24 PM
Unknown Object (File)
Sep 14 2025, 2:48 AM
Unknown Object (File)
Sep 13 2025, 8:01 AM
Subscribers

Details

Summary

vmbus_synic_setup(), is invoked via vmbus_intrhook -> vmbus_doattach -> smp_rendezvous. On !EARLY_AP_STARTUP (e.g., aarch64), SMP isn't functional in intrhooks and smp_rendezvous() will just call vmbus_synic_setup() on the boot AP. There's nothing that will initialize the pcpu data on every other AP.
To fix it we need to use SI_SUB_SMP for vmbus_doattach().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/hyperv/vmbus/vmbus.c
1534

This code should just go away entirely, there is no !EARLY_AP_STARTUP platform where it will ever call vmbus_doattach here.

1586

There's a reference to cold down here in the sysinit that should also go away, we should just always call vmbus_doattach() if we're doing the sysinit -- it *has* to be positioned at a point where "thread scheduling is possible".

schakrabarti_microsoft.com marked an inline comment as done.
schakrabarti_microsoft.com marked an inline comment as done.
This revision is now accepted and ready to land.Jun 6 2023, 7:54 AM
This revision was automatically updated to reflect the committed changes.