Page MenuHomeFreeBSD

ofw: remove trailing line
AbandonedPublic

Authored by christos on May 25 2023, 7:06 PM.
Tags
None
Referenced Files
F153203341: D40272.diff
Sun, Apr 19, 7:06 PM
Unknown Object (File)
Sun, Apr 12, 6:28 PM
Unknown Object (File)
Sat, Apr 11, 9:27 AM
Unknown Object (File)
Mon, Apr 6, 7:32 PM
Unknown Object (File)
Mar 13 2026, 5:48 PM
Unknown Object (File)
Mar 13 2026, 11:49 AM
Unknown Object (File)
Mar 12 2026, 8:24 PM
Unknown Object (File)
Feb 28 2026, 3:49 AM
Subscribers

Details

Reviewers
markj

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51691
Build 48582: arc lint + arc unit

Event Timeline

Just for context, there used to be a style rule which said you need a blank line at the beginning of a function body that doesn't contain any local variables. We don't require this anymore, but there is lots of code in the tree which has it.

In general I would discourage this kind of patch, especially if it won't be MFCed to stable/13. If you don't MFC, then an attempt to merge a subsequent commit to stable/13 might fail due to merge conflicts.

It might be better to just abandon this revision then.