Page MenuHomeFreeBSD
Differential D40272

ofw: remove trailing line
AbandonedPublic
Actions

Authored by christos on May 25 2023, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 5:51 PM
Unknown Object (File)
Sun, Nov 9, 4:36 PM
Unknown Object (File)
Sun, Nov 9, 4:36 PM
Unknown Object (File)
Sun, Nov 9, 12:31 PM
Unknown Object (File)
Fri, Nov 7, 1:31 AM
Unknown Object (File)
Sat, Nov 1, 5:37 AM
Unknown Object (File)
Wed, Oct 29, 7:11 AM
Unknown Object (File)
Oct 12 2025, 12:52 PM
View All 62 Files
Subscribers
imp

Details

Reviewers
markj

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51691
Build 48582: arc lint + arc unit

Event Timeline

christos created this revision.May 25 2023, 7:06 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2023, 7:06 PM
christos requested review of this revision.May 25 2023, 7:06 PM
Harbormaster completed remote builds in B51691: Diff 122436.May 25 2023, 7:06 PM
markj added a comment.May 25 2023, 8:10 PM

Just for context, there used to be a style rule which said you need a blank line at the beginning of a function body that doesn't contain any local variables. We don't require this anymore, but there is lots of code in the tree which has it.

In general I would discourage this kind of patch, especially if it won't be MFCed to stable/13. If you don't MFC, then an attempt to merge a subsequent commit to stable/13 might fail due to merge conflicts.

christos added a comment.May 25 2023, 8:12 PM

It might be better to just abandon this revision then.

christos abandoned this revision.May 25 2023, 8:43 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
ofw/
1 line

Diff 122436

View Options

sys/dev/ofw/ofwbus.c

Loading...