Page MenuHomeFreeBSD

ofw: remove redundant calls in ofwbus_attach()
ClosedPublic

Authored by christos on May 25 2023, 7:05 PM.
Tags
None
Referenced Files
F80211422: D40271.diff
Fri, Mar 29, 7:04 AM
Unknown Object (File)
Dec 23 2023, 9:26 AM
Unknown Object (File)
Dec 12 2023, 4:22 AM
Unknown Object (File)
Nov 21 2023, 6:18 PM
Unknown Object (File)
Nov 14 2023, 4:43 AM
Unknown Object (File)
Nov 12 2023, 5:06 AM
Unknown Object (File)
Nov 12 2023, 2:22 AM
Unknown Object (File)
Nov 11 2023, 2:56 PM
Subscribers

Details

Summary

This patch improves the fix introduced in 38594ff9c0c9. Calling
ofw_bus_gen_setup_devinfo() is redundant when we are calling
simplebus_add_device().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This seems ok, but a good commit message will explain the what and the why a bit more.

If you look at the revision where ofwbus_attach() was introduced, the code structure is similar, but there the _setup_dinfo call was not redundant. It returned a structure which becomes the ivars ("instance variables") of a child device. Today, that device_set_ivars() call happens in simplebus_add_device(). This change happened in commit ecaecbc7d8bc212d8e854088106b3b21e631bb52.

Approved, but I suggest expanding the commit message a bit.

This revision is now accepted and ready to land.May 25 2023, 8:19 PM
christos retitled this revision from ofw: remove useless calls in ofwbus_attach() to ofw: remove redundant calls in ofwbus_attach().May 25 2023, 8:46 PM