ofw: remove redundant calls in ofwbus_attach()
ClosedPublic
Actions

Authored by christos on May 25 2023, 7:05 PM.

Details

Reviewers

Commits

rG9105ba047181: ofw: remove redundant calls in ofwbus_attach()

Summary

This patch improves the fix introduced in 38594ff9c0c9. Calling
ofw_bus_gen_setup_devinfo() is redundant when we are calling
simplebus_add_device().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.May 25 2023, 7:05 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 25 2023, 7:05 PM

christos requested review of this revision.May 25 2023, 7:05 PM

Harbormaster completed remote builds in B51690: Diff 122435.May 25 2023, 7:05 PM

This seems ok, but a good commit message will explain the what and the why a bit more.

If you look at the revision where ofwbus_attach() was introduced, the code structure is similar, but there the _setup_dinfo call was not redundant. It returned a structure which becomes the ivars ("instance variables") of a child device. Today, that device_set_ivars() call happens in simplebus_add_device(). This change happened in commit ecaecbc7d8bc212d8e854088106b3b21e631bb52.

Approved, but I suggest expanding the commit message a bit.

This revision is now accepted and ready to land.May 25 2023, 8:19 PM

christos retitled this revision from ofw: remove useless calls in ofwbus_attach() to ofw: remove redundant calls in ofwbus_attach().May 25 2023, 8:46 PM

Closed by commit rG9105ba047181: ofw: remove redundant calls in ofwbus_attach() (authored by christos). · Explain WhyMay 25 2023, 8:48 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG9105ba047181: ofw: remove redundant calls in ofwbus_attach().