kinst: be explicit about trampoline placement
ClosedPublic
Actions

Authored by christos on May 25 2023, 4:06 PM.

Tags

None

Referenced Files

	F167070976: D40266.id122443.diff
	Tue, Aug 18, 8:39 PM

	F167024752: D40266.diff
	Tue, Aug 18, 3:52 PM

	Unknown Object (File)
	Mon, Aug 17, 1:52 PM

	Unknown Object (File)
	Sun, Aug 9, 9:25 AM

	Unknown Object (File)
	Sun, Aug 9, 9:25 AM

	Unknown Object (File)
	Sun, Aug 9, 9:21 AM

	Unknown Object (File)
	Sun, Jul 26, 10:53 PM

	Unknown Object (File)
	Jul 9 2026, 2:56 PM

View All Files

Subscribers

imp

Details

Reviewers

markj

Commits

rG855ade9e722a: kinst: be explicit about trampoline placement

Summary

The current implementation and comment was specific to amd64. Even
though in the case of kinst's supported architectures (RISC-V and ARM64)
VM_MIN_KERNEL_ADDRESS is equal to KERNBASE, it's better to be explicit.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.May 25 2023, 4:06 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 25 2023, 4:06 PM

christos requested review of this revision.May 25 2023, 4:06 PM

Harbormaster completed remote builds in B51680: Diff 122416.May 25 2023, 4:06 PM

Approved

This revision is now accepted and ready to land.May 25 2023, 8:30 PM

Closed by commit rG855ade9e722a: kinst: be explicit about trampoline placement (authored by christos). · Explain WhyMay 25 2023, 8:41 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG855ade9e722a: kinst: be explicit about trampoline placement.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

kinst/

trampoline.c

19 lines

Diff 122443

View Options

sys/cddl/dev/kinst/trampoline.c

kinst: be explicit about trampoline placementClosedPublicActions