graphics/spectacle: make pipewire optional

[vvd]

Summary

Tested on 13.2 amd64.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270982

[arrowd]

This diff doesn't apply with arc too. Can you please re-generate it using Arcanist?

[vvd]

I think it was copy&paste from console issue - tabs replaced with spaces and etc.
"git diff > spectacle.diff" and uploaded file spectacle.diff now.

[arrowd]

graphics/spectacle/files/extra-patch-pipewire-off

11

Double negation looks weird. Can you rename the CMake variable to ENABLE_PIPEWIRE?

32

[arrowd]

graphics/spectacle/files/extra-patch-pipewire-off

11

Ah, nevermind, krfb already has a variable that is named DISABLE_*.

[vvd]

BTW, using spectacle with this patch for 3 weeks - screenshots work fine.

[arrowd]

Address another my comment and it should be fine.

[arrowd]

graphics/spectacle/files/extra-patch-pipewire-off

50

72

Where does this definition gets added? CMake doesn't add all its variables as -D flags to the compiler. You probably need to look at some sort of config.h.in and add this variable there.

[arrowd]

graphics/spectacle/files/extra-patch-pipewire-off

13

Actually, this check isn't needed at all. If KPipeWire wasn't found, CMake will stop due to REQUIRED keyword`. If it didn't then no need to check for KPipeWire_FOUND.

[vvd]

graphics/spectacle/files/extra-patch-pipewire-off

11

Yes, it was made like in krfb.

32

Do I need to update the patch?

50

What about line #30?
Same "if(PIPEWIRE_FOUND)".

72

Maybe this one "set(PIPEWIRE_FOUND 1)"?
And yes - it's work as expected.
I'm using it for 3 weeks already.

[arrowd]

graphics/spectacle/files/extra-patch-pipewire-off

12

You don't need PIPEWIRE_FOUND at all, just use NOT DISABLE_PIPEWIRE.

[vvd]

Added #cmakedefine PIPEWIRE_FOUND 1 to pass on option PIPEWIRE_FOUND from cmake to sources.