Page MenuHomeFreeBSD

src.conf: add WITH_TOOLCHAIN description
ClosedPublic

Authored by emaste on May 2 2023, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 6:56 AM
Unknown Object (File)
Dec 12 2023, 4:00 AM
Unknown Object (File)
Nov 27 2023, 7:13 AM
Unknown Object (File)
Nov 25 2023, 11:47 AM
Unknown Object (File)
Nov 22 2023, 9:08 AM
Unknown Object (File)
Nov 22 2023, 9:06 AM
Unknown Object (File)
Nov 22 2023, 9:02 AM
Unknown Object (File)
Nov 11 2023, 10:46 AM
Subscribers
None

Details

Summary

It is not used by the in-tree default configuration, but adding it
allows downstream projects with different defaults to make use of
Cirrus-CI.

(Posting this one for review for the general idea; if this is generally agreeable I'll just add others that I come across.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.May 2 2023, 5:30 PM
emaste created this revision.

Looks good to me.
IMHO, we shouldn't have WITH and WITHOUT files, but just TOOLCHAIN, etc and reword the options if needed to cope with any asymmetry between WITH and WITHOUT phrasing today that's relevant.
But this change is great,

This revision is now accepted and ready to land.May 3 2023, 3:29 PM

IMHO, we shouldn't have WITH and WITHOUT files, but just TOOLCHAIN, etc and reword the options if needed to cope with any asymmetry between WITH and WITHOUT phrasing today that's relevant.

I agree we should do something like this (after Kyle's rework), as long as we can avoid reducing clarity. At the very least we should be able to remove one of the pair when we have both WITH_ and WITHOUT_ descriptions.

tools/build/options/WITH_TOOLCHAIN
2
This revision was automatically updated to reflect the committed changes.