Fix various Coverity issues in savecore
ClosedPublic
Actions

Authored by asomers on Oct 23 2015, 3:24 PM.

Details

Reviewers

Commits

rS289845: Fix various Coverity issues in sbin/savecore/savecore.c:

Summary

Fix various Coverity issues in savecore.c:
CID1009429: Fix unchecked return value from lseek while clearing dump
CID1007781: Fix file descriptor leak in DoFile
CID1007261: Don't send potentially unterminated string to syslog(3)

Test Plan

Create and save dumps with various savecore options

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 9660.Oct 23 2015, 3:24 PM

asomers retitled this revision from to Fix various Coverity issues in savecore.

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added a reviewer: markj.

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2015, 3:24 PM

markj accepted this revision.Oct 23 2015, 5:53 PM

markj edited edge metadata.

markj added inline comments.

sbin/savecore/savecore.c
731 ↗	(On Diff #9660)	Missing parens for sizeof. It also feels a bit unusual to me to have the write() call on the RHS here.

This revision is now accepted and ready to land.Oct 23 2015, 5:53 PM

Closed by commit rS289845: Fix various Coverity issues in sbin/savecore/savecore.c: (authored by asomers). · Explain WhyOct 23 2015, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

savecore/

savecore.c

12 lines

Diff 9666

View Options

head/sbin/savecore/savecore.c

Fix various Coverity issues in savecoreClosedPublicActions