urtwn(4): fix mbuf leak in the TX path
ClosedPublic
Actions

Authored by avos on Oct 22 2015, 9:52 PM.

Details

Reviewers

kevlo
adrian

Commits

rS289891: urtwn(4): fix mbuf leak in the TX path

Test Plan

Tested with RTL8188EU, STA mode

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 9644.Oct 22 2015, 9:52 PM

avos retitled this revision from to urtwn(4): fix mbuf leak in the TX path.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 22 2015, 9:52 PM

Hi,

I'd rather than we build a mostly sensible, consistent way of dealing with things with the USB drivers. Here, I'd like txeof to take an mbuf/txbuf and free it. That way all of the dequeue logic is done in the USB tx callback and it's not broken out. When we start seeing drivers do both USB and non-USB then i'd like there to be a shared txeof that makes no actual assumption that the underlying queuing is done via USB.

However yeah, the USB completion callback can leak buffers in specific instances. So let's fix that and keep XXX_txeof() take the softc and the txbuf to complete.