Page MenuHomeFreeBSD

Enhance USES=shebangfix a bit more.
ClosedPublic

Authored by mat on Oct 22 2015, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 12, 9:20 AM
Unknown Object (File)
Tue, Nov 4, 10:17 PM
Unknown Object (File)
Tue, Nov 4, 10:09 PM
Unknown Object (File)
Sep 2 2025, 1:07 PM
Unknown Object (File)
Sep 1 2025, 2:59 AM
Unknown Object (File)
Aug 25 2025, 10:16 PM
Unknown Object (File)
Jul 23 2025, 11:42 AM
Unknown Object (File)
Jul 14 2025, 10:11 AM
Subscribers
None

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 896
Build 896: arc lint + arc unit

Event Timeline

mat retitled this revision from to Enhance USES=shebangfix a bit more..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: wblock.
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
1146

Maybe s/This/The shebangfix macro/

1149

This is a long sentence with four nonspecific "it"s. This would make more sense if at least the first one was replaced with the specific thing, and the sentence split:

The shebangfix macro is run from within ${WRKSRC}, so it can deal with paths that are relative to ${WRKSRC}.
It can also deal with absolute paths if files outside of ${WRKSRC} require patching.
1176

The first sentence has a confusing if(if()) thing.

interp_OLD_CMD can contain multiple values.  Any entries with spaces must be quoted.

For the second sentence, probably better not to use an existing entry. If that one has to be used, maybe say that this is the internal implementation.

1184

Try to avoid if/then sentences with a pause. Use declarative and "when" when possible."

Some software uses strange locations for an interpreter.  For example, an application
might expect Python to be located in /opt/bin/python2.7.  The strange path to be replaced can be declared in the port Makefile:
1196

s/should/must/

But maybe it reads better to say:

If scripts are created with incorrect shebangs during the build phase, the build process must be patched to generate correct shebangs."  (This is a little unclear about whether the "build process" means only what happens in the port `build` target.
1197

Emphasis on "correct" is not really necessary, but put it first:

Correct paths for supported interpreters are available in interp_CMD.
mat marked 6 inline comments as done.Oct 27 2015, 9:00 AM
This revision was automatically updated to reflect the committed changes.