Details
Details
- Reviewers
wblock - Commits
- rD47681: Enhance USES=shebangfix a bit more.
Diff Detail
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml | ||
|---|---|---|
| 1146 ↗ | (On Diff #9623) | Maybe s/This/The shebangfix macro/ |
| 1149 ↗ | (On Diff #9623) | This is a long sentence with four nonspecific "it"s. This would make more sense if at least the first one was replaced with the specific thing, and the sentence split: The shebangfix macro is run from within ${WRKSRC}, so it can deal with paths that are relative to ${WRKSRC}.
It can also deal with absolute paths if files outside of ${WRKSRC} require patching. |
| 1176 ↗ | (On Diff #9623) | The first sentence has a confusing if(if()) thing. interp_OLD_CMD can contain multiple values. Any entries with spaces must be quoted. For the second sentence, probably better not to use an existing entry. If that one has to be used, maybe say that this is the internal implementation. |
| 1184 ↗ | (On Diff #9623) | Try to avoid if/then sentences with a pause. Use declarative and "when" when possible." Some software uses strange locations for an interpreter. For example, an application might expect Python to be located in /opt/bin/python2.7. The strange path to be replaced can be declared in the port Makefile: |
| 1196 ↗ | (On Diff #9623) | s/should/must/ But maybe it reads better to say: If scripts are created with incorrect shebangs during the build phase, the build process must be patched to generate correct shebangs." (This is a little unclear about whether the "build process" means only what happens in the port `build` target. |
| 1197 ↗ | (On Diff #9623) | Emphasis on "correct" is not really necessary, but put it first: Correct paths for supported interpreters are available in interp_CMD. |