math/trlan: fix build for base system WITH_LLVM_BINUTILS
ClosedPublic
Actions

Authored by emaste on Apr 21 2023, 8:24 PM.

Details

Reviewers

jrm

Commits

R11:e6b5fb28a560: math/trlan: fix build for base system WITH_LLVM_BINUTILS

Summary

Use strip --strip-unneeded instead of strip -x.  strip -x strips all
non-global symbols, but there are some non-global symbols referenced by
relocations.  ELF Tool Chain strip and GNU strip silently retain those
symbols, but LLVM strip is more strict and reports an error.

PR:             270958
Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Apr 21 2023, 8:24 PM

emaste created this revision.

emaste added inline comments.Apr 24 2023, 5:49 PM

math/trlan/Makefile
51	or we could just drop `-x` and not replace it with `--strip-unneeded`, just install the unstripped .a. It's not clear what's the "right" thing to do wrt stripping .a archives - for example, see this Red Hat bug report https://bugzilla.redhat.com/show_bug.cgi?id=1395280 or our tcl bug report https://core.tcl-lang.org/tcl/tktview/718de2132f487cf29dfdd0be2b90fcc0107c2aa7 the `strip -x` was here from inception, 9f04bb57b17ee

As we discussed privately, we don't usually strip static libraries, so either not stripping or --strip-uneeeded would be fine.

Also worth noting that the tarball isn't fetchable except from our cache and the site from WWW, http://crd.lbl.gov/~kewu/trlan.html, gives an HTTP 404. It might be best to mark this port as deprecated.

This revision is now accepted and ready to land.Apr 24 2023, 6:53 PM

Closed by commit R11:e6b5fb28a560: math/trlan: fix build for base system WITH_LLVM_BINUTILS (authored by emaste). · Explain WhyApr 24 2023, 7:06 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: R11:e6b5fb28a560: math/trlan: fix build for base system WITH_LLVM_BINUTILS.