Page MenuHomeFreeBSD

install: clarify fsync() used in safe (-S) mode
Needs ReviewPublic

Authored by marck on Apr 21 2023, 7:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 4, 6:02 PM
Unknown Object (File)
Sat, Aug 15, 5:05 AM
Unknown Object (File)
Wed, Aug 12, 5:36 PM
Unknown Object (File)
Tue, Aug 11, 8:36 PM
Unknown Object (File)
Mon, Aug 10, 12:30 PM
Unknown Object (File)
Sun, Aug 9, 3:28 PM
Unknown Object (File)
Sun, Aug 9, 1:32 PM
Unknown Object (File)
Sun, Aug 9, 11:28 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

install(1) uses fsync between writing to temporary file and renaming it to the target;
sometimes this is unclear as install -S could be slow in wdrain state while fsync()ing.

Clarify this moment in the man page a bit.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

marck requested review of this revision.Apr 21 2023, 7:21 AM

I think it would be nicer to add an option to do the rename bit but *not* fsync

poudriere is doing -S and it kills i/o perf