Lockfiles, and thus crates lists, should be generated after patching completes, which may include Cargo.toml. Also accounts for ${EXTRA_PATCHES} passed specifically for this target to, for example, make additional packages visible (as only the root Cargo.toml is read)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 50521 Build 47412: arc lint + arc unit
Event Timeline
Comment Actions
It's using extract because extract is the bare minimum dependency where generate-lockfile could possibly work. Sometimes you don't want the patches applied. If we change it to patch then we have to manually move the patches out the way first in that case. With extract people can just run make patch cargo-crates when they need the patches applied first.
However this isn't super important, so feel free to commit it anyway.
Using extract also means cargo-crates-merge is broken for ports with patches.