Differential D39127

vfs: retire KERN_VNODE
ClosedPublic
Actions

Authored by mjg on Mar 16 2023, 5:25 PM.

Tags

None

Referenced Files

	F137750184: D39127.diff
	Tue, Nov 25, 11:40 AM

	Unknown Object (File)
	Thu, Nov 20, 10:40 AM

	Unknown Object (File)
	Thu, Nov 20, 10:40 AM

	Unknown Object (File)
	Thu, Nov 20, 10:39 AM

	Unknown Object (File)
	Thu, Nov 20, 10:35 AM

	Unknown Object (File)
	Thu, Nov 20, 8:19 AM

	Unknown Object (File)
	Thu, Nov 6, 3:45 AM

	Unknown Object (File)
	Wed, Nov 5, 12:59 AM

Subscribers

Details

Reviewers

Commits

rG62a573d9537c: vfs: retire KERN_VNODE

Summary

It got disabled in 2003:

commit acb18acfec97aa7fe26ff48f80a5c3f89c9b542d
Author: Poul-Henning Kamp <phk@FreeBSD.org>
Date:   Sun Feb 23 18:09:05 2003 +0000

    Bracket the kern.vnode sysctl in #ifdef notyet because it results
    in massive locking issues on diskless systems.

    It is also not clear that this sysctl is non-dangerous in its
    requirements for locked down memory on large RAM systems.

There does not seem to be practical use for it and the disabled routine
does not work anyway.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Mar 16 2023, 5:25 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2023, 5:25 PM

mjg requested review of this revision.Mar 16 2023, 5:25 PM

kib accepted this revision.Mar 17 2023, 11:30 AM

kib added inline comments.

sys/sys/sysctl.h
978	Please use C89 comments in the public file. Why not use the single-line style as you did in kern_xxx.c?

This revision is now accepted and ready to land.Mar 17 2023, 11:30 AM

Closed by commit rG62a573d9537c: vfs: retire KERN_VNODE (authored by mjg). · Explain WhyMar 17 2023, 4:27 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rG62a573d9537c: vfs: retire KERN_VNODE.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

11 lines

sys/

kern/

9 lines

97 lines

security/

audit/

audit_bsm_klib.c

1 line

sys/

2 lines

30 lines

Diff 119017

lib/libc/gen/sysctl.3

Loading...

sys/kern/kern_xxx.c

Loading...

sys/kern/vfs_subr.c

Loading...

sys/security/audit/audit_bsm_klib.c

Loading...

sys/sys/sysctl.h

Loading...

sys/sys/vnode.h

Loading...