Page MenuHomeFreeBSD
Differential D39078

secure_getenv: Improve documentation wording
ClosedPublic
Actions

Authored by imp on Mar 14 2023, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 14 2025, 2:21 AM
Unknown Object (File)
Oct 14 2025, 2:21 AM
Unknown Object (File)
Oct 14 2025, 2:21 AM
Unknown Object (File)
Oct 14 2025, 2:21 AM
Unknown Object (File)
Oct 13 2025, 12:51 PM
Unknown Object (File)
Oct 12 2025, 5:35 AM
Unknown Object (File)
Jul 23 2025, 8:41 PM
Unknown Object (File)
Jul 13 2025, 1:16 AM
View All 62 Files
Subscribers
None

Details

Reviewers
mjg
jrtc27
Summary

Improve the documentation wording to be more consistent with FreeBSD
manual pages.

Suggested by: mjg (though reworded)
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50367
Build 47258: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 14 2023, 5:03 PM
imp created this revision.
Harbormaster completed remote builds in B50359: Diff 118809.Mar 14 2023, 5:03 PM
imp added reviewers: mjg, jrtc27.Mar 14 2023, 5:03 PM
mjg added inline comments.Mar 14 2023, 5:05 PM
lib/libc/stdlib/getenv.3
90

" is "?

mjg added a comment.Mar 14 2023, 5:06 PM

lgtm otherwise, but will wait for some other native speaker to stamp this :)

jrtc27 added inline comments.Mar 14 2023, 11:50 PM
lib/libc/stdlib/getenv.3
224

glibc-compatible

imp updated this revision to Diff 118826.Mar 15 2023, 12:02 AM

jrtc27's hyphen

Harbormaster completed remote builds in B50366: Diff 118826.Mar 15 2023, 12:02 AM
jrtc27 added a comment.Mar 15 2023, 12:03 AM

mjg's "is"?

imp updated this revision to Diff 118830.Mar 15 2023, 12:21 AM

oh, add a missing is here...

Harbormaster completed remote builds in B50367: Diff 118830.Mar 15 2023, 12:21 AM
mjg accepted this revision.Mar 16 2023, 7:21 PM
This revision is now accepted and ready to land.Mar 16 2023, 7:21 PM
jrtc27 accepted this revision.Mar 16 2023, 7:25 PM
imp closed this revision.Jul 30 2024, 5:20 AM

I landed this, or something somewhat similar in d5df268584209c448d2e3f344b8b15c944e48b82

Revision Contents
Changeset List

PathSize
lib/
libc/
stdlib/
30 lines

Diff 118830

View Options

lib/libc/stdlib/getenv.3

Loading...