Page MenuHomeFreeBSD
Differential D38980

partedit: limit APM partitions to __powerpc__
Needs ReviewPublic
Actions

Authored by emaste on Mar 8 2023, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 12:36 AM
Unknown Object (File)
Nov 22 2024, 5:10 PM
Unknown Object (File)
Oct 24 2024, 2:43 AM
Unknown Object (File)
Oct 3 2024, 7:35 AM
Unknown Object (File)
Sep 23 2024, 6:18 PM
Unknown Object (File)
Sep 10 2024, 9:18 PM
Unknown Object (File)
Sep 10 2024, 6:40 PM
Unknown Object (File)
Sep 8 2024, 6:37 PM
View All 23 Files
Subscribers
None

Details

Reviewers
kevans
jrtc27
Summary

APM is used on old PowerPC Macs, and is not relevant on other machines.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 8 2023, 1:09 PM
emaste created this revision.
emaste added a comment.Mar 8 2023, 1:20 PM

I didn't try to limit MBR/GPT/BSD disklabels as they are potentially applicable to many different architectures.

jrtc27 added a comment.Mar 8 2023, 3:52 PM

What if I’m preparing a disk for another system? It only really makes sense to limit in the installer IMO.

emaste added a comment.Mar 8 2023, 4:08 PM

Would you suggest we check argv[0] and remove APM only if it's not sade?

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
partedit/
2 lines

Diff 118525

View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...