Page MenuHomeFreeBSD
Differential D38980

partedit: limit APM partitions to __powerpc__
Needs ReviewPublic
Actions

Authored by emaste on Mar 8 2023, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 27, 10:16 PM
Unknown Object (File)
Wed, Nov 26, 6:35 AM
Unknown Object (File)
Mon, Nov 24, 9:48 PM
Unknown Object (File)
Nov 2 2025, 6:41 PM
Unknown Object (File)
Oct 19 2025, 11:49 AM
Unknown Object (File)
Oct 19 2025, 11:49 AM
Unknown Object (File)
Oct 18 2025, 9:53 PM
Unknown Object (File)
Oct 16 2025, 12:25 AM
View All 50 Files
Subscribers
None

Details

Reviewers
kevans
jrtc27
Summary

APM is used on old PowerPC Macs, and is not relevant on other machines.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 8 2023, 1:09 PM
emaste created this revision.
emaste added a comment.Mar 8 2023, 1:20 PM

I didn't try to limit MBR/GPT/BSD disklabels as they are potentially applicable to many different architectures.

jrtc27 added a comment.Mar 8 2023, 3:52 PM

What if I’m preparing a disk for another system? It only really makes sense to limit in the installer IMO.

emaste added a comment.Mar 8 2023, 4:08 PM

Would you suggest we check argv[0] and remove APM only if it's not sade?

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
partedit/
2 lines

Diff 118525

View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...