Page MenuHomeFreeBSD

x11/albert: Update to 0.20.5
ClosedPublic

Authored by jsm on Feb 7 2023, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 4:45 AM
Unknown Object (File)
Sat, Nov 23, 5:48 AM
Unknown Object (File)
Thu, Nov 14, 7:08 PM
Unknown Object (File)
Sun, Nov 10, 9:50 AM
Unknown Object (File)
Sun, Nov 10, 9:26 AM
Unknown Object (File)
Sun, Nov 10, 6:29 AM
Unknown Object (File)
Oct 30 2024, 10:14 AM
Unknown Object (File)
Oct 23 2024, 4:24 AM
Subscribers

Details

Summary

x11/albert: Update to 0.20.5

Test Plan

tested in poudirere, and tested some runtime.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jsm requested review of this revision.Feb 7 2023, 6:31 PM
jsm created this revision.
arrowd added inline comments.
x11/albert/Makefile
15

This can be just play:audio/sox.

17

While at it, can you please sort these values?

20

Sort these too.

25

Extra space at the beginning of the value?

29

By convention placeholder values are wrapped in %%. Can you please change LOCALBASE here and in patches into %%LOCALBASE%%?

x11/albert/files/patch-plugins_calculator__qalculate_CMakeLists.txt
7 ↗(On Diff #116715)

Are these patches actually needed if you add :ldflags to USES=localbase?

x11/albert/files/patch-plugins_files_src_plugin.cpp
2

It'd be great to have an explanation for this patch in the patch's header.

Assume "trash:///" on FreeBSD as well as Linux, sort USES. use %%LOCALBASE%% instead of LOCALBASE as placeholders.

localbase:ldflags works for the math plugins skips patches and postpatch

jsm marked 5 inline comments as done.Mar 1 2023, 9:12 PM
jsm added inline comments.
x11/albert/files/patch-plugins_files_src_plugin.cpp
2

I changed it to just do as on Linux.

jsm marked an inline comment as done.Mar 2 2023, 8:57 PM
jsm added inline comments.
x11/albert/Makefile
25

I cannot find the extra space either after git apply, or in the raw diff. Can you?

LGTM.

x11/albert/Makefile
25

Nor do I. Probably a Phab's glitch.

This revision is now accepted and ready to land.Mar 3 2023, 6:51 AM
This revision was automatically updated to reflect the committed changes.