Page MenuHomeFreeBSD
Differential D38415

tarfs: Silence warnings when no supported compression is enabled.
ClosedPublic
Actions

Authored by des on Feb 7 2023, 1:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 9:12 PM
Unknown Object (File)
Thu, Oct 2, 3:15 AM
Unknown Object (File)
Wed, Oct 1, 1:33 PM
Unknown Object (File)
Mon, Sep 29, 4:08 AM
Unknown Object (File)
Wed, Sep 24, 6:50 PM
Unknown Object (File)
Aug 23 2025, 6:28 PM
Unknown Object (File)
Aug 14 2025, 1:35 PM
Unknown Object (File)
Aug 7 2025, 2:04 PM
View All 63 Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
Klara
Commits
rG146d9da6c2ec: tarfs: Silence warnings when no supported compression is enabled.
Summary

Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 7 2023, 1:27 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 7 2023, 1:27 PM
des requested review of this revision.Feb 7 2023, 1:27 PM
Harbormaster completed remote builds in B49597: Diff 116692.Feb 7 2023, 1:27 PM
kib added inline comments.Feb 7 2023, 1:35 PM
sys/fs/tarfs/tarfs_io.c
43

Why not write #ifdef ZSTDIO, same as in other places?

And why do you need TARFS_ZIO, instead of reusing ZSTDIO?

des marked an inline comment as done.Feb 7 2023, 3:03 PM
des added inline comments.
sys/fs/tarfs/tarfs_io.c
43

Because I have branches with support for zlib and xz compression as well. The code which is #ifdef TARFS_ZIO is common to all three, not specific to zstd. I didn't include the other two in the initial code drop because they don't support seekable compression without upstream changes.

kib accepted this revision.Feb 7 2023, 4:25 PM
kib added inline comments.
sys/fs/tarfs/tarfs_io.c
43

Then at least add this explanation to the commit message. Otherwise it would cause the same question from other people, I am sure.

This revision is now accepted and ready to land.Feb 7 2023, 4:25 PM
Closed by commit rG146d9da6c2ec: tarfs: Silence warnings when no supported compression is enabled. (authored by des). · Explain WhyFeb 7 2023, 5:31 PM
This revision was automatically updated to reflect the committed changes.
des marked an inline comment as done.
des added a commit: rG146d9da6c2ec: tarfs: Silence warnings when no supported compression is enabled..

Revision Contents
Changeset List

PathSize
sys/
fs/
tarfs/
16 lines

Diff 116710

View Options

sys/fs/tarfs/tarfs_io.c

Loading...