Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.
Details
Details
- Reviewers
kib - Group Reviewers
Klara - Commits
- rG146d9da6c2ec: tarfs: Silence warnings when no supported compression is enabled.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/fs/tarfs/tarfs_io.c | ||
|---|---|---|
| 43 | Why not write #ifdef ZSTDIO, same as in other places? And why do you need TARFS_ZIO, instead of reusing ZSTDIO? | |
| sys/fs/tarfs/tarfs_io.c | ||
|---|---|---|
| 43 | Because I have branches with support for zlib and xz compression as well. The code which is #ifdef TARFS_ZIO is common to all three, not specific to zstd. I didn't include the other two in the initial code drop because they don't support seekable compression without upstream changes. | |
| sys/fs/tarfs/tarfs_io.c | ||
|---|---|---|
| 43 | Then at least add this explanation to the commit message. Otherwise it would cause the same question from other people, I am sure. | |