Differential D384

Add vxlan pseudo device
ClosedPublic
Actions

Authored by bryanv on Jul 9 2014, 6:50 AM.

Tags

None

Referenced Files

	F110294573: D384.id642.diff
	Sun, Feb 16, 9:22 AM

	Unknown Object (File)
	Jan 13 2025, 4:30 PM

	Unknown Object (File)
	Dec 7 2024, 5:29 PM

	Unknown Object (File)
	Nov 30 2024, 3:36 PM

	Unknown Object (File)
	Nov 30 2024, 3:34 PM

	Unknown Object (File)
	Nov 1 2024, 12:38 PM

	Unknown Object (File)
	Nov 1 2024, 12:38 PM

	Unknown Object (File)
	Nov 1 2024, 12:38 PM

Subscribers

None

Details

Reviewers

Commits

rS273331: Add vxlan interface

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bryanv updated this revision to Diff 642.Jul 9 2014, 6:50 AM

bryanv retitled this revision from to Add vxlan pseudo device.

bryanv updated this object.

bryanv edited the test plan for this revision. (Show Details)

bryanv added a reviewer: gnn.

bryanv updated this revision to Diff 643.Jul 9 2014, 7:05 AM

I also saw the update and I am fine with it.

In my view of this it seems like there are two space indents which are not consistent with style(9). Is that because this is seen in a web browser or is the indent really incorrect?

Other than the indentation issue the code looks OK to me.

In D384#4, @gnn wrote:

I also saw the update and I am fine with it.

In my view of this it seems like there are two space indents which are not consistent with style(9). Is that because this is seen in a web browser or is the indent really incorrect?

Other than the indentation issue the code looks OK to me.

I think that is just Phabricator. The code should be pretty close to style(9).

Yes, I checked with other folks on IRC and they confirmed that the indentation gets messed up in phabricator, but that folks are working on that. So, I'm good with this code. You can say I reviewed it.

gnn accepted this revision.Jul 14 2014, 4:29 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Jul 14 2014, 4:29 PM

Closed by commit rS273331 (authored by @bryanv).

Revision Contents
Changeset List

Path

Size

head/

sbin/

ifconfig/

1 line

73 lines

648 lines

share/

man/

man4/

2 lines

235 lines

sys/

conf/

4 lines

1 line

modules/

1 line

if_vxlan/

9 lines

net/

148 lines

3089 lines

sys/

1 line

Diff 2053

head/sbin/ifconfig/Makefile

Loading...

head/sbin/ifconfig/ifconfig.8

Loading...

head/sbin/ifconfig/ifvxlan.c

Loading...

head/share/man/man4/Makefile

Loading...

head/share/man/man4/vxlan.4

Loading...

head/sys/conf/NOTES

Loading...

head/sys/conf/files

Loading...

head/sys/modules/Makefile

Loading...

head/sys/modules/if_vxlan/Makefile

Loading...

head/sys/net/if_vxlan.h

Loading...

head/sys/net/if_vxlan.c

Loading...

head/sys/sys/priv.h

Loading...