urtwn(4): separate R92C_MSR register from R92C_CR register
ClosedPublic
Actions

Authored by avos on Oct 7 2015, 4:43 PM.

Details

Reviewers

kevlo
adrian

Commits

rS289811: - Split one 4-byte R92C_CR register into 2-byte R92C_CR and 1-byte R92C_MSR

Summary

Do not mix these two registers - they are used for different purpose.

Partially based on NetBSD's if_urtwnreg.h.

Test Plan

Tested with RTL8188EU, STA mode.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9219.Oct 7 2015, 4:43 PM

avos retitled this revision from to urtwn(4): separate R92C_MSR register from R92C_CR register.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 7 2015, 4:43 PM

avos added a child revision: D3840: urtwn(4): set short/long retry limits.Oct 7 2015, 7:38 PM

Add urtwn_set_mode()

If Kevin is okay with this then I'm okay!

This revision is now accepted and ready to land.Oct 22 2015, 9:48 PM

kevlo accepted this revision.Oct 23 2015, 1:45 AM

kevlo edited edge metadata.

Closed by commit rS289811: - Split one 4-byte R92C_CR register into 2-byte R92C_CR and 1-byte R92C_MSR (authored by avos). · Explain WhyOct 23 2015, 8:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

if_urtwn.c

24 lines

if_urtwnreg.h

34 lines

Diff 9648

View Options

head/sys/dev/usb/wlan/if_urtwn.c