Differential D38235

smp: Drop confusing braces and return statement as panic() is never returns.
ClosedPublic
Actions

Authored by dchagin on Jan 28 2023, 10:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 8, 12:29 PM

	Unknown Object (File)
	Sun, Feb 8, 7:07 AM

	Unknown Object (File)
	Sat, Jan 31, 6:46 AM

	Unknown Object (File)
	Wed, Jan 14, 9:05 PM

	Unknown Object (File)
	Dec 25 2025, 11:08 PM

	Unknown Object (File)
	Nov 12 2025, 4:40 AM

	Unknown Object (File)
	Nov 6 2025, 3:15 AM

	Unknown Object (File)
	Nov 2 2025, 5:14 AM

Subscribers

Details

Reviewers

kib
imp

Commits

rGe600dd820db3: smp: Drop confusing braces and return statement as panic() is never returns.
rG6fdf04a2be9b: smp: Drop confusing braces and return statement as panic() is never returns.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Jan 28 2023, 10:33 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 28 2023, 10:33 AM

dchagin requested review of this revision.Jan 28 2023, 10:33 AM

Harbormaster completed remote builds in B49276: Diff 115968.Jan 28 2023, 10:33 AM

dchagin added a reviewer: kib.Jan 28 2023, 3:23 PM

Looks good. The rest of the file adheres to the old 'no {} for single statement' style.

This revision is now accepted and ready to land.Jan 28 2023, 5:06 PM

kib accepted this revision.Jan 28 2023, 6:03 PM

Closed by commit rG6fdf04a2be9b: smp: Drop confusing braces and return statement as panic() is never returns. (authored by dchagin). · Explain WhyJan 29 2023, 12:38 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG6fdf04a2be9b: smp: Drop confusing braces and return statement as panic() is never returns..

dchagin added a commit: rGe600dd820db3: smp: Drop confusing braces and return statement as panic() is never returns..Feb 6 2023, 7:08 PM

Revision Contents
Changeset List

Path

Size

sys/

x86/

x86/

5 lines

Diff 115998

sys/x86/x86/mp_x86.c

Loading...