loader: md: Use default func for fmtdev and parsedev
ClosedPublic
Actions

Authored by manu on Jan 27 2023, 6:35 AM.

Details

Reviewers

Group Reviewers

Commits

rG86957b873f99: loader: md: Use default func for fmtdev and parsedev
rG04afa8cc370e: loader: md: Use default func for fmtdev and parsedev

Summary

The default function are enough for md so use them instead of the
disks ones that doesn't work for it anymore.

Sponsored by: Beckhoff Automation GmbH & Co. KG
MFC after: now

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Jan 27 2023, 6:35 AM

Herald added subscribers: dab, imp. · View Herald TranscriptJan 27 2023, 6:35 AM

manu requested review of this revision.Jan 27 2023, 6:35 AM

Harbormaster completed remote builds in B49256: Diff 115910.Jan 27 2023, 6:35 AM

manu added a reviewer: Loader.Jan 27 2023, 6:35 AM

manu mentioned this in D38211: loader: Fix md device name parsing.

manu retitled this revision from leader: md: Use default func for fmtdev and parsedev to loader: md: Use default func for fmtdev and parsedev.Jan 27 2023, 7:10 AM

This will work and won't break anything.
It does mean, though, you can't have things like md0p2:, but IMHO, that's fine. There's no use cases for that and this makes things simpler and easier.
I'll have to see if this means we can make it not be a DEVT_DISK or not, but that's a longer-term project of mine ending that abuse ...

imp accepted this revision.Jan 27 2023, 5:52 PM

This revision is now accepted and ready to land.Jan 27 2023, 5:52 PM

Closed by commit rG04afa8cc370e: loader: md: Use default func for fmtdev and parsedev (authored by manu). · Explain WhyJan 27 2023, 6:07 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG04afa8cc370e: loader: md: Use default func for fmtdev and parsedev.

manu added a commit: rG86957b873f99: loader: md: Use default func for fmtdev and parsedev.