aio_waitcomplete(2) should not sleep when timeout is not NULL, but set to 0.

[jhb]

sys/kern/vfs_aio.c

2511

Maybe make a smaller diff by checking for timo == -1 in here? That is, just

while (...) {
    if (timo == -1) {
        error = EWOULDBLOCK;
        break;
    }
}

I've seen this pattern in other places in the kernel. Often the sleep is done in the else in this case. Also, even though EGAIN == EWOULDBLOCK on FreeBSD, EWOULDBLOCK (or EINPROGRESS) better matches the existing error descriptions in the aio_waitcomplete(2) manpage. It is also what other places in the kernel use when skipping a sleep due to a poll.

[jhb]

Also, this thing should just be converting the timespec directly to an sbintime_t and using mtx_sleep_sbt() or whatever it is called.

[jhb]

In D3814#78778, @jhb wrote:

Also, this thing should just be converting the timespec directly to an sbintime_t and using mtx_sleep_sbt() or whatever it is called.

Though that can be done in a follow up change (sorry, meant to say that originally)

[pjd]

Thanks John, both good suggestions.