Differential D38020

libcasper.3: document cap_init's single-threaded program requirement
ClosedPublic
Actions

Authored by asomers on Jan 10 2023, 7:03 PM.

Tags

None

Referenced Files

	F148085262: D38020.id.diff
	Sun, Mar 15, 4:12 PM

	F148038609: D38020.id.diff
	Sun, Mar 15, 8:29 AM

	Unknown Object (File)
	Sat, Mar 14, 8:58 PM

	Unknown Object (File)
	Sat, Mar 14, 7:06 PM

	Unknown Object (File)
	Fri, Feb 27, 8:31 PM

	Unknown Object (File)
	Fri, Feb 27, 10:03 AM

	Unknown Object (File)
	Feb 8 2026, 10:09 AM

	Unknown Object (File)
	Feb 8 2026, 6:15 AM

Subscribers

Details

Reviewers

emaste
imp

Commits

rGdb1cdf2fabfe: libcasper.3: document cap_init's single-threaded program requirement

Summary

Because it internally forks.

[skip ci]
MFC after: 1 week
Sponsored by: Axcient

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jan 10 2023, 7:03 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 10 2023, 7:03 PM

asomers requested review of this revision.Jan 10 2023, 7:03 PM

Harbormaster completed remote builds in B49053: Diff 114940.Jan 10 2023, 7:03 PM

imp accepted this revision.Jan 10 2023, 7:06 PM

imp added inline comments.

lib/libcasper/libcasper/libcasper.3
99	Currently single threaded programs, or programs that haven't yet started additional threads? I suppose the former is more correct, but maybe the latter is easier to follow? But just a suggestion... If you don't like it, I'm good with what's here.

This revision is now accepted and ready to land.Jan 10 2023, 7:06 PM

emaste accepted this revision.Jan 10 2023, 7:17 PM

emaste added inline comments.

lib/libcasper/libcasper/libcasper.3
99	"currently" reads somewhat strangely to me too. Maybe something like "in a single-threaded context" or "before additional threads (if any) are started"? In any case like @imp I think it's better to have something here so up to you.

asomers added inline comments.Jan 10 2023, 7:52 PM

lib/libcasper/libcasper/libcasper.3
99	"single-threaded context" sounds nice. I'll use that one.

Closed by commit rGdb1cdf2fabfe: libcasper.3: document cap_init's single-threaded program requirement (authored by asomers). · Explain WhyJan 10 2023, 7:54 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rGdb1cdf2fabfe: libcasper.3: document cap_init's single-threaded program requirement.

Revision Contents
Changeset List

Path

Size

lib/

libcasper/

libcasper/

3 lines

Diff 114942

lib/libcasper/libcasper/libcasper.3

Loading...