Differential D3763

wpi(4): use more correct types
ClosedPublic
Actions

Authored by avos on Oct 1 2015, 2:24 PM.

Details

Reviewers

adrian

Commits

rS289124: wpi(4): use more correct types.

Test Plan

Tested with Intel 3945BG, STA mode

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9012.Oct 1 2015, 2:24 PM

avos retitled this revision from to wpi(4): use more correct types.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 1 2015, 2:24 PM

Hi,

So there are a lot of changes from int to something else. I think you should explain to people why the changes are useful as part of the description.

For example, people tend to just use 'int' for array iteration, and you've changed a handful of those over to be uint8_t. Why's that?

In D3763#79519, @adrian wrote:

Hi,

So there are a lot of changes from int to something else. I think you should explain to people why the changes are useful as part of the description.

For example, people tend to just use 'int' for array iteration, and you've changed a handful of those over to be uint8_t. Why's that?

This change fixes some amount of -Wsign-conversion and -Wconversion warnings + sets correct sizes for some variables (as a result, some loop counters were touched too).

Closed by commit rS289124: wpi(4): use more correct types. (authored by adrian). · Explain WhyOct 11 2015, 1:31 AM

This revision was automatically updated to reflect the committed changes.