restore: fix restore of NFS4 ACLs
ClosedPublic
Actions

Authored by chs on Dec 6 2022, 10:24 PM.

Details

Reviewers

Commits

rG9dda00df7e8f: restore: fix restore of NFS4 ACLs

Summary

Changing the mode bits on a file with an NFS4 ACL results in theNFS4 ACL being replaced by one matching the new mode bits being set, so when restoring a file with an NFS4 ACL, set the owner/group/mode first and then set the NFS4 ACL, so that setting the mode does not throw away the ACL that we just set.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chs created this revision.Dec 6 2022, 10:24 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 6 2022, 10:24 PM

chs requested review of this revision.Dec 6 2022, 10:24 PM

Harbormaster completed remote builds in B48635: Diff 113898.Dec 6 2022, 10:24 PM

chs retitled this revision from Changing the mode bits on a file with an NFS4 ACL results in the NFS4 ACL being replaced by one matching the new mode bits being set, so when restoring a file with an NFS4 ACL, set the owner/group/mode first and then set the NFS4 ACL, so that... to restore: fix restore of NFS4 ACLs.Dec 6 2022, 10:26 PM

chs edited the summary of this revision. (Show Details)

These changes look correct to me.

This revision is now accepted and ready to land.Dec 11 2022, 1:03 AM

Closed by commit rG9dda00df7e8f: restore: fix restore of NFS4 ACLs (authored by chs). · Explain WhyDec 12 2022, 4:20 PM

This revision was automatically updated to reflect the committed changes.

chs added a commit: rG9dda00df7e8f: restore: fix restore of NFS4 ACLs.